Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github workflow to check that links in repo are good #61

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Add github workflow to check that links in repo are good #61

merged 10 commits into from
Jul 17, 2024

Conversation

kheal
Copy link
Collaborator

@kheal kheal commented Jul 16, 2024 •
edited
Loading

This PR addresses #59.

It adds two github workflows. One chron job that checks for broken links every day and logs an issue if any are broken. A second github issue that triggers on a pull request and fails if it finds broken links on the PR.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your PR link to an issue?
  • Have you described the changes this PR will make?

@kheal kheal requested a review from brynnz22 July 16, 2024 23:47
@kheal kheal marked this pull request as ready for review July 16, 2024 23:55
@kheal kheal changed the title 59 githubaction urlchecker Add github workflow to check that links in repo are good Jul 16, 2024
@kheal kheal linked an issue Jul 16, 2024 that may be closed by this pull request
Implement Github action that checks that all urls resolve (should trigger on PR) #59
Closed
brynnz22
brynnz22 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@brynnz22 brynnz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! cool to see how these work. Its nice you added one to run everyday since the links seem to break all the time! Great idea.

@brynnz22 brynnz22 merged commit e1faccb into main Jul 17, 2024
1 check passed
@brynnz22 brynnz22 deleted the 59_githubaction_urlchecker branch July 17, 2024 00:02
@kheal
Copy link
Collaborator Author

kheal commented Jul 17, 2024

Yeah, it's fun to learn new things! They are surprisingly simple if you can use cookie cutters like I did.

@kheal kheal mentioned this pull request Jul 22, 2024
Closed
3 tasks
@kheal kheal mentioned this pull request Aug 1, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brynnz22 brynnz22 brynnz22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Github action that checks that all urls resolve (should trigger on PR)
2 participants
@kheal @brynnz22