Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

berkeley issue with DataObject records from import_automation #267

Closed
aclum opened this issue Oct 8, 2024 · 0 comments · Fixed by #274
Closed

berkeley issue with DataObject records from import_automation #267

aclum opened this issue Oct 8, 2024 · 0 comments · Fixed by #274
Assignees
Labels
berkeley-rollout-post-mvp-eligible does not block rolling out the MVP, still targeted for Oct import priority-high

Comments

@aclum
Copy link
Contributor

aclum commented Oct 8, 2024

Example record from import automation
[DataObject(id='nmdc:abcd', type='nmdc:DataObject', name='Metagenome bin tarfiles archive', description='Metagenome Bins for nmdc:omprc-11-importT', alternative_identifiers=[], compression_type=None, data_category=None, data_object_type=FileTypeEnum(text='Metagenome Bins', description='Metagenome bin contigs fasta'), file_size_bytes=14065, insdc_experiment_identifiers=[], md5_checksum='3ba455a6a73bdd37cfdc81299fea942c']

This will not pass API validation with either json:validate or the workflow_executions post endpoint b/c data_category requires an enumeration.

Either fix #259 to remove empty keys or add support for specifying the correct enumeration values.
If doing the former we still should have spin off a ticket to add support for this later.
If doing the latter outputs of NucleotideSequencing would have a permissible value of 'instrument_data' and outputs of WorkflowExecution would have a permissible value of processed_data. A permissible value of workflow_parameter_data is only valid for mass spec data at this time.

@aclum aclum added the berkeley-rollout-post-mvp-eligible does not block rolling out the MVP, still targeted for Oct label Oct 9, 2024
@mbthornton-lbl mbthornton-lbl moved this from 📝 Todo to 🏗 In Progress in Berkeley-Schema Refactor Roll Out Oct 14, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Berkeley-Schema Refactor Roll Out Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
berkeley-rollout-post-mvp-eligible does not block rolling out the MVP, still targeted for Oct import priority-high
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants