Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update import logic to update OmicsProcessing record #239

Closed
aclum opened this issue Aug 20, 2024 · 3 comments · Fixed by #274
Closed

update import logic to update OmicsProcessing record #239

aclum opened this issue Aug 20, 2024 · 3 comments · Fixed by #274

Comments

@aclum
Copy link
Contributor

aclum commented Aug 20, 2024

The import automation should make a DataObject record and add is to has_output on the NucelotideSequencing record. The NucelotideSequencing record will be part of the import csv file. I believe nmdc_automation/import_automation/activity_mapper.py is where this needs to be updated. It needs to do this instead of the current behavior which is to make a ReadQc record without an input data object.

We talked about doing this with a queries:run command since the NucelotideSequencing record will already exist.

When updating for this issue, also address:

@ssarrafan
Copy link

@mbthornton-lbl @scanon @aclum can this one be closed this sprint?

@aclum
Copy link
Contributor Author

aclum commented Oct 4, 2024

Work has not started on this, moving to the next sprint. This will be worked on once #251 is done.

@ssarrafan
Copy link

251 is closed. PR being reviewed now. Hopefully it can be closed by Friday?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants