Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating a submission with string or list of strings for packageName #1491

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

This is a bit of follow on work to the changes for #1367.

These changes allow a client to create a new submission using either a list of strings or single string for the packageName field. The reason for this comes down to the fact that the release cycle for the Field Notes app is decoupled from the nmdc-server release cycle (by necessity, due to app store review delays).

The app already knows how to deal with packageName values coming from the server that are either string or lists of strings. But when creating a new submission, the app doesn't know a priori whether the server will accept a single string or an array of strings for the packageName. We will release an update to the app to make it send an array of strings by default, but it will take a little bit of time to get that change into user devices. In the meantime the app will continue sending a single string packageName for new submissions, and these backend changes will help ease that transition period.

P.S. In the future I'd like to use the information from the /api/version endpoint to make decisions in the app about which features the server supports. Hopefully that will mean fewer backend changes like this in the future. But it'll take a bit of architectural work in the app to do that, and that sadly isn't the top priority at the moment.

@pkalita-lbl pkalita-lbl merged commit 48a99fe into main Dec 11, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the fix-allow-string-package-name-on-create branch December 11, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants