Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample metadata issues from Chris #448

Closed
3 of 11 tasks
pvangay opened this issue Jul 8, 2021 · 8 comments
Closed
3 of 11 tasks

Sample metadata issues from Chris #448

pvangay opened this issue Jul 8, 2021 · 8 comments
Assignees
Milestone

Comments

@pvangay
Copy link

pvangay commented Jul 8, 2021

Consolidated issues that haven't already been captured elsewhere from @cmungall's document here:

  • Allow for alternative ways to search for KEGG terms (e.g. by function name instead of KO term)
  • Make sure that units are explicit in the data object (i.e. Depth search is in cm, but this field is stored in meters so the search doesn't work correctly). This may be related to the depth range issue.
  • Every CURIE should be hyperlinked: IGSN, GOLD, ENVO. See https://microbiomedata.github.io/nmdc-schema/identifiers.html. When displaying a CURIE, always retrieval minimal metadata to display. MUST have a label field, this should be shown. SHOULD have a description field, this may be shown as a tooltip
  • Provide tooltips for every field using the description field from schema
  • Indicate when a term is from MIxS
  • All quantitative values should show units, this is stored in the JSON as both the verbatim value (e.g. 0.15m) and as a normalized tuple (value=0.15, unit=m)
  • Individual sample page - consider adding: omics processing metadata and sample prep metadata, elevation, environmental package

Nice to have:

  • GOLD - if sublevels are non-discriminatory then auto-expand; e.g. if I am looking already at fracking samples, then I have to click 5 times to see
  • Consider showing some key metadata terms (EnvO) with each sample (in the sample results list)
  • Allow search results to be bookmarkable
  • Improve UI of individual Sample Page - too much white space on the right. consider map.
@subdavis subdavis removed their assignment Jul 17, 2021
@ssarrafan ssarrafan added this to the Sprint 8 milestone Oct 29, 2021
@ssarrafan
Copy link

I assigned this to @cmungall and @pvangay to make sure we can clarify what we need Kitware to do before we assign it to them. @dehays can these be discussed at the metadata meeting next week?

@ssarrafan
Copy link

This is on the agenda for the metadata meeting on Dec 1st so I'm moving this to the December sprint. @dehays @pvangay

@ssarrafan
Copy link

ssarrafan commented Dec 2, 2021

@ssarrafan
Copy link

@pvangay and @cmungall would you like me to keep this issue open still? I've created GH issues for Brandon from the list but let me know if this issue should still remain open until everything is done.

@pvangay
Copy link
Author

pvangay commented Dec 14, 2021

i think it's already captured elsewhere, makes sense to close.

@ssarrafan
Copy link

Closing this issue since the details and tasks are captured in other GH issues.

@aclum
Copy link
Contributor

aclum commented Jan 2, 2024

@ljohnson09 previous user research from Chris on the data portal

@aclum
Copy link
Contributor

aclum commented Jan 10, 2024

@ljohnson09 Note a lot of these tickets are not actually complete, but rather that we eventually ended up with duplicate tickets and so some of the older tickets got closed out but are still not resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants