-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate MIxS 6 submodule with nmdc-schema, make new import #292
Conversation
This PR is mostly concerned with creating a new, dynamic MIxS import for the nmdc-schema. It would replace the mostly static MIxS 5-based See these issue comments: |
This PR now includes all MIxS 6 slots used by all environmental packages in the NMDC DH schema. Notes
|
Manual checks that should probably become tests
|
Reviewing this. Will add comments soon. |
I'm reviewing this PR and the new submodule process, by running and testing the Makefile targets. Here is the list of commands that I ran one after the other:
The mixs_new.yaml file got generated successfully and replaced the old mixs.yaml. |
add try except block around call to remove()
merge from main
Goal
Update the MIxS integration in NMDC soon after Apr 28th release
@turbomam: minimize changed files. Give PR and issue a better name.
Not all of the reviewers are expected to pour over all of the changes.
See Issue #291
src/schema/mixs.yaml