[POST-berkeley
-MERGER] Update FunctionalAnnotationAggMember
class for compatibility with MetaP Aggregation tables
#2202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was moved from the berkeley branch to this repo. Original PR found here: microbiomedata#242
Description
This PR will
FunctionalAnnotationAggMember
class to be able to accomodate both annotations from metagenomics and metaproteomics analyses. This is accomplished by exchanging the slotmetagenome_anlaysis_id
with the existing slotwas_generated_by
.metagenome_anlaysis_id
slot as there are now no classes using this slot.count
slotFunctionalAnnotationAggMember
class that is a combination ofwas_generated_by
andgene_function_id
This PR will close 1253 and 2155 and partially address 2028
Reviewers
For review (when out of draft stage):
@mslarae13, @aclum, @SamuelPurvine, @eecavanna
To keep informed:
@naglepuff, @mbthornton-lbl, @corilo, @sujaypatil96, @brynnz22
PR Information
What type of PR is this? (check all applicable)
slot
Related Issues
Did you add/update any tests?
Could this schema change make it so any valid data becomes invalid?
If you answered "Yes", does this PR branch include that migrator?
Does this PR have any downstream implications?
We will need to update the aggregation scripts (issue filed here: Update generate_metap_agg.py script to source ids from new slot nmdc-aggregator#13) and the data portal to use the new slot