Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POST-berkeley-MERGER] Update FunctionalAnnotationAggMember class for compatibility with MetaP Aggregation tables #2202

Closed
wants to merge 15 commits into from

Conversation

kheal
Copy link
Contributor

@kheal kheal commented Oct 8, 2024

This was moved from the berkeley branch to this repo. Original PR found here: microbiomedata#242

Description

This PR will

  1. Modify the existing FunctionalAnnotationAggMember class to be able to accomodate both annotations from metagenomics and metaproteomics analyses. This is accomplished by exchanging the slot metagenome_anlaysis_id with the existing slot was_generated_by.
  2. Implement a migrator to adjust existing records.
  3. Deprecate the metagenome_anlaysis_id slot as there are now no classes using this slot.
  4. Update tests accordingly
  5. Add description to count slot
  6. Add a unique_keys to FunctionalAnnotationAggMember class that is a combination of was_generated_byandgene_function_id

This PR will close 1253 and 2155 and partially address 2028

Reviewers

For review (when out of draft stage):
@mslarae13, @aclum, @SamuelPurvine, @eecavanna
To keep informed:
@naglepuff, @mbthornton-lbl, @corilo, @sujaypatil96, @brynnz22

PR Information

What type of PR is this? (check all applicable)

  • Schema change: Structure and content
    • deleted a slot

Related Issues

  • Fixes: 1253
  • Related Issue(s): #

Did you add/update any tests?

  • Yes
    • All example yamls are updated (including invalid examples
    • Doctest for migrator added
    • Added invalid example for FunctionalAnnotationAggMember to check for rule on count slot

Could this schema change make it so any valid data becomes invalid?

  • Yes (A migrator is required)

If you answered "Yes", does this PR branch include that migrator?

  • Yes

Does this PR have any downstream implications?

@kheal kheal marked this pull request as draft October 8, 2024 22:26
@kheal kheal self-assigned this Oct 8, 2024
@kheal kheal closed this Oct 8, 2024
@mslarae13
Copy link
Contributor

@kheal can you add why this was closed and not merged? I'm guessing it was moved to nmdc-schema. But want to make sure we have good record keeping

@kheal
Copy link
Contributor Author

kheal commented Oct 18, 2024

Yes it was moved #2203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit FunctionalAnnotationAggMember to work with MetaP data
2 participants