Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

berkeley breakdown AnalyteCategoryEnum into types allowable for NucleotideSequencing and MassSpectrometry #2154

Open
aclum opened this issue Aug 8, 2024 · 2 comments · May be fixed by #2249
Open

berkeley breakdown AnalyteCategoryEnum into types allowable for NucleotideSequencing and MassSpectrometry #2154

aclum opened this issue Aug 8, 2024 · 2 comments · May be fixed by #2249
Assignees
@samobermiller

Comments

@aclum
Copy link
Contributor

aclum commented Aug 8, 2024

Not required before the rollout but at some point we should break down AnalyteCategoryEnum into enumerations specific to subcategories. At present it would be valid to have analyte_category populated with nom for class NucleotideSequencing

cc @mslarae13
@mslarae13 mslarae13 moved this to Post Berk Roll Out in Berkeley-Schema Refactor Roll Out Aug 16, 2024
@aclum aclum mentioned this issue Aug 29, 2024
Closed
@kheal
Copy link
Contributor

kheal commented Nov 5, 2024

We can add rule on the MassSpectrometry and NucleotideSequencing subclasses to specify acceptable PVs for the analyte_category slot. Although analyte_category is only currently used on DataGeneration I think we'd need to rename that slot if we wanted to use separate Enums (and then migrate).

@kheal
Copy link
Contributor

kheal commented Nov 5, 2024 •
edited
Loading

@samobermiller - please add titles to the PVs in AnalyteCategoryEnum at this same time. See discussion in microbiomedata/nmdc-server#1326 for why.

@samobermiller samobermiller linked a pull request Nov 7, 2024 that will close this issue
Draft
@samobermiller samobermiller linked a pull request Nov 7, 2024 that will close this issue
update PVs for subclasses NucleotideSequencing and MassSpectrometry, post berkeley #2249
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samobermiller samobermiller

Labels
None yet
Projects
Berkeley-Schema Refactor Roll Out
Status: Post Berk Roll Out
Milestone
No milestone
3 participants
@aclum @kheal @samobermiller