Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

berkeley Replace references to OmicsProcessing with DataGeneration #1326

Closed
mslarae13 opened this issue Mar 30, 2023 · 9 comments
Closed

berkeley Replace references to OmicsProcessing with DataGeneration #1326

mslarae13 opened this issue Mar 30, 2023 · 9 comments
Assignees

Comments

@mslarae13
Copy link

Under “Omics” bar chart, it is not intuitive to have Organic Matter there, since that is not an omics data type
(this is a broader issue than just the Omics bar chart, but that is where attendees noted it)

Screen Shot 2023-03-30 at 12 38 13 PM
Screen Shot 2023-03-30 at 12 38 19 PM

@aclum
Copy link
Contributor

aclum commented Apr 22, 2024

Berkeley schema will update this to DataGeneration.

@ssarrafan
Copy link

Screenshot 2024-08-02 at 12 37 48 PM It now says Natural Organic Matter. @mslarae13 do you still want this removed from the omics type drop down?

@aclum
Copy link
Contributor

aclum commented Aug 5, 2024

@naglepuff is the faceted search header hard coded or dynamic based on the class name? If hard coded could it be updated to Data Type in the berkeley nmdc-server branch.

@aclum aclum transferred this issue from microbiomedata/issues Aug 5, 2024
@aclum aclum moved this to Search in Data Portal Aug 5, 2024
@aclum
Copy link
Contributor

aclum commented Aug 6, 2024

Looking at https://data-berkeley.microbiomedata.org/ references to Omics are hard coded. Please update, in the berkeley nmdc-server branch the following:
Omics Processing header in faceted search to Data Generation
Omics type in faceted search to Data type
Omics in the bar chart to Data type

cc @mslarae13

@naglepuff naglepuff mentioned this issue Aug 6, 2024
8 tasks
@aclum aclum changed the title Having Organic Mater in the "omics" bar chart and data search is not intuitive. berkeley Replace references to OmicsProcessing with DataGeneration Aug 8, 2024
@ssarrafan ssarrafan moved this to 👀 In Review in Berkeley-Schema Refactor Roll Out Aug 12, 2024
@aclum
Copy link
Contributor

aclum commented Aug 21, 2024

@naglepuff I don't see these changes in the berkeley data portal? I though @eecavanna redeployed this a few days ago so I was expecting to see to those changes in the UI.
Screenshot 2024-08-21 at 12 56 41 PM

@naglepuff
Copy link
Collaborator

I just redeployed the front and back end services, and I see the changes. The change must not have been merged into the feature branch for the redeployment that you mentioned.

@github-project-automation github-project-automation bot moved this from Search to External links in Data Portal Aug 22, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Berkeley-Schema Refactor Roll Out Aug 22, 2024
@mslarae13
Copy link
Author

@aclum thoughts... this might be getting nit-picky.. but

Screenshot 2024-08-22 at 8 40 46 AM

Metagenome vs Proteomics

Metagenomics & Proteomics

or

Metagenome & Proteome ??

@aclum
Copy link
Contributor

aclum commented Aug 23, 2024

That is the same as it is now, once berkeley gets pushed out I suggest we add a title slot to AnalyteCategoryEnum permissible values and use consistent vocab.

@aclum
Copy link
Contributor

aclum commented Aug 29, 2024

ticket for title slot for AnalyteCategoryEnum
microbiomedata/nmdc-schema#2154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Status: External links
Development

No branches or pull requests

4 participants