-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for change in alldocs
field name from type
to _type_and_ancestors
#851
Conversation
I would like to see this accompanied by a test to guard against future changes. #817 appears to the PR that introduced this problem where I would have expected a failed test. I did see that @eecavanna made some comments recently #725 Also since the endpoint is not working as expected we should discuss if this should be a hotfix. I would prefer this instead of waiting until the next monthly release cc @pkalita-lbl @shreddd |
@sujaypatil96 - can you add a test to ensure that we have a way to verify that the endpoint is working moving forward? |
NVM - I see the testing being addressed in #725 |
alldocs
field name from type
to _type_and_ancestors
alldocs
field name from type
to _type_and_ancestors
In case y'all want to merge in the tests I have written already (they are in branch 725, which is part of draft PR 849) and build on top of those in this branch, that would be OK with me. One way you could do that is by editing PR 849 so that its "base branch" is this |
I was thinking the same thing @eecavanna. I'll help add more test cases to PR #849 today. We can edit the "base branch" to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging to update base of #849
Side note: My git client is not showing the original branch ( Hi @dwinston, did you by any chance merge these changes in with a "squash" commit (via something other than the GitHub UI)? |
In this PR we are updating the logic for the
/data_objects/study/{study_id}
endpoint to use the newly renamed field name inalldocs
called_type_and_ancestors
(which previously used to be calledtype
).Details
...
Related issue(s)
Fixes #850
Related subsystem(s)
docs
directory)Testing
I tested these changes by...
Documentation
docs
directory)Maintainability
study_id: str
)# TODO
or# FIXME
black
to format all the Python files I created/modified