Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changesheets examples #841

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

aclum
Copy link
Contributor

@aclum aclum commented Dec 13, 2024

...

Related subsystem(s)

  • Runtime API (except the Minter)
  • Minter
  • Dagster
  • Project documentation (in the docs directory)
  • Translators (metadata ingest pipelines)
  • MongoDB migrations
  • Other

Testing

  • I tested these changes (explain below)
  • I did not test these changes

I tested these changes using changesheets:validate on runtime prod.

Documentation

  • I have not checked for relevant documentation yet (e.g. in the docs directory)
  • I have updated all relevant documentation so it will remain accurate
  • Other (explain below)

this is a documentation update

Maintainability

  • Every Python function I defined includes a docstring (test functions are exempt from this)
  • Every Python function parameter I introduced includes a type hint (e.g. study_id: str)
  • All "to do" or "fix me" Python comments I added begin with either # TODO or # FIXME
  • I used black to format all the Python files I created/modified
  • The PR title is in the imperative mood (e.g. "Do X") and not the declarative mood (e.g. "Does X" or "Did X")

Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these changes using changesheets:validate on runtime prod.

Works for me — thanks for testing them!

@eecavanna eecavanna merged commit dbed7e8 into main Dec 13, 2024
@eecavanna eecavanna deleted the changesheets_example_updates branch December 13, 2024 23:46
@dwinston
Copy link
Collaborator

dwinston commented Dec 17, 2024

@dwinston
Copy link
Collaborator

I realize now that this PR, because it did not change e.g. a *.py file, did not trigger a CI run.

@eecavanna
Copy link
Collaborator

eecavanna commented Dec 17, 2024

Thanks for bringing this to our attention, @dwinston.

  1. I will file a ticket about this regression: Runtime API reports example changesheet as being invalid #844
  2. I will file a ticket about adding this directory to the list of directories in which changes trigger a CI run (in an attempt to avoid this situation in the future): GHA does not run automated tests when example changesheets are modified #843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants