Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to GOLD translator to ignore field research sites #833

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

sujaypatil96
Copy link
Collaborator

@sujaypatil96 sujaypatil96 commented Dec 12, 2024

In this PR, we are modifying the GOLD translator in such a way that it has the capability of ignoring/accepting the creation of field research sites based on a configuration parameter (include_field_site_info). By default it is set to False meaning it will not be created.

Details

...

Related issue(s)

Required to finish these:

...

Related subsystem(s)

  • Runtime API (except the Minter)
  • Minter
  • Dagster
  • Project documentation (in the docs directory)
  • Translators (metadata ingest pipelines)
  • MongoDB migrations
  • Other

Testing

  • I tested these changes (explain below)
  • I did not test these changes

I tested these changes by...

Documentation

  • I have not checked for relevant documentation yet (e.g. in the docs directory)
  • I have updated all relevant documentation so it will remain accurate
  • Other (explain below)

Maintainability

  • Every Python function I defined includes a docstring (test functions are exempt from this)
  • Every Python function parameter I introduced includes a type hint (e.g. study_id: str)
  • All "to do" or "fix me" Python comments I added begin with either # TODO or # FIXME
  • I used black to format all the Python files I created/modified
  • The PR title is in the imperative mood (e.g. "Do X") and not the declarative mood (e.g. "Does X" or "Did X")

@sujaypatil96
Copy link
Collaborator Author

#836 has been addressed in 7ea94eb, otherwise the objective of this PR is to make sure that field research sites are only populated conditionally, i.e., based on the value of include_field_site_info in the Dagit interface.

@sujaypatil96 sujaypatil96 marked this pull request as ready for review December 12, 2024 23:29
@sujaypatil96 sujaypatil96 merged commit 22a9a58 into main Dec 13, 2024
2 checks passed
@sujaypatil96 sujaypatil96 deleted the remove-site-info-gold-translator branch December 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GOLD translator should infer analyte_category from sequencingStrategy
2 participants