Fix handling of GOLD and JGI IDs in submission data translator #773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes update the submission portal data translator to place the JGI proposal ID into the
jgi_portal_study_identifiers
slot onStudy
. Previously it was placing it inalternative_identifiers
, which is all that was available when the translation code was originally written.Details
Additional minor changes:
GOLD:
to GOLD study IDs. This has been updated togold:
.Translator._get_curie()
method has been renamed toTranslator._ensure_curie()
. The behavior and calling semantics have been changed a bit to clarify that it will not add a prefix if the provided identifier already has one. See test cases intests/test_data/test_translator.py
for examples.tests/test_data/test_submission_portal_translator_data.yaml
has been updated with GOLD and JGI IDs to exercise the updated code.Related issue(s)
These issues were uncovered while working on microbiomedata/issues#888
Related subsystem(s)
docs
directory)Testing
Added/updated automated tests
Documentation
docs
directory)N/A
Maintainability
study_id: str
)# TODO
or# FIXME
black
to format all the Python files I created/modified