Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the 11.0.3-to-11.1.0 migration notebook #761

Conversation

eecavanna
Copy link
Collaborator

@eecavanna eecavanna commented Nov 12, 2024

In this branch, I created a new migration notebook. This one can be used to migrate the Mongo database from conforming to schema version 11.0.3 to conforming to schema version 11.1.0.

There is a caveat, though: Since the new schema hasn't been released yet, I don't know what its version number will actually be. I have assumed it will be 11.1.0, but that may not be what it ends up being—in which case, I'll update this branch.

Details

I also moved some notes from the notebook to the example config file. Finally, I changed the import section so that the migrator gets imported based upon a string variable. That will make it easier for us to transition from using a notebook to using a regular Python script (we can pass the string in as a CLI argument).

Related issue(s)

Fixes #760

Related subsystem(s)

  • Runtime API (except the Minter)
  • Minter
  • Dagster
  • Project documentation (in the docs directory)
  • MongoDB migrations
  • Other

Testing

  • I tested these changes (explain below)
  • I have not tested these changes yet

I tested the notebook locally against a copy of production data.

Documentation

  • I have not checked for relevant documentation yet (e.g. in the docs directory)
  • I have updated all relevant documentation so it will remain accurate
  • Other (explain below)

Maintainability

  • Every Python function I defined includes a docstring (test functions are exempt from this)
  • Every Python function parameter I introduced includes a type hint (e.g. study_id: str)
  • All "to do" or "fix me" Python comments I added begin with either # TODO or # FIXME
  • I used black to format all the Python files I created/modified
  • The PR title is in the imperative mood (e.g. "Do X") and not the declarative mood (e.g. "Does X" or "Did X")

@eecavanna eecavanna self-assigned this Nov 12, 2024
@eecavanna eecavanna marked this pull request as ready for review November 13, 2024 01:27
@eecavanna
Copy link
Collaborator Author

I'm merging the migration notebook in without additional review (as usual).

@eecavanna eecavanna merged commit 6aaa1da into main Nov 13, 2024
@eecavanna eecavanna deleted the 760-migrations-implement-notebook-that-runs-the-1103-to-1110-migrators branch November 13, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrations: Implement notebook that runs the 11.0.3-to-11.1.0 migrators
1 participant