Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Fix bug in "progress bar" logic and work around upstream memory leak #757

Conversation

eecavanna
Copy link
Collaborator

In this branch, I updated the latest migration notebook in the following ways:

  1. I fixed a bug where the notebook would sometimes divide by zero (Migrations: Validation progress bar logic divides by zero when collection is small (oops) #751)
  2. I worked around an upstream bug (Memory leak when serializing ValidationReport instance or its results list as a whole linkml/linkml#2395) that would result in a memory leak when serializing the validation report as a whole
  3. I removed some extraneous whitespace from one of the cells

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration, if it is not simply make up-test && make test-run.

  • Many, many, many, grueling, tedious, slogging manual runs of the affected notebook cell in PyCharm

Definition of Done (DoD) Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas

The bug in the "progress bar" logic was reported here:
#751

The upstream memory leak was reported here:
linkml/linkml#2395
@eecavanna eecavanna self-assigned this Nov 9, 2024
@eecavanna eecavanna added the X SMALL Less than 1 day label Nov 9, 2024
@eecavanna eecavanna marked this pull request as ready for review November 9, 2024 08:10
@eecavanna eecavanna merged commit 1e9f9c2 into main Nov 9, 2024
@eecavanna eecavanna deleted the 751-migrations-validation-progress-bar-logic-divides-by-zero-when-collection-is-small-oops branch November 9, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X SMALL Less than 1 day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrations: Validation progress bar logic divides by zero when collection is small (oops)
1 participant