Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Update notebook to omit Mongo credentials from commands when authentication is disabled #745

Conversation

eecavanna
Copy link
Collaborator

@eecavanna eecavanna commented Oct 31, 2024

Description

In this branch, I updated the latest migration notebook so that it (a) automatically omits authentication-related CLI options from Mongo CLI commands when no such authentication information is configured in the notebook's environment; and (b) it prints a "." to the console (as a "sign of life/activity/heartbeat") whenever it validates an additional 10% of the documents in a given collection.

Fixes #672 and #719

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration, if it is not simply make up-test && make test-run.

  • I ran the unit tests that target the help function involved
    shell $ python -m unittest -v demo/metadata_migration/notebooks/test_helpers.py

Definition of Done (DoD) Checklist:

  • My code follows the style guidelines of this project (have you run black nmdc_runtime/?)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (in docs/ and in https://github.com/microbiomedata/NMDC_documentation/?)
  • I have added tests that prove my fix is effective or that my feature works, incl. considering downstream usage (e.g. https://github.com/microbiomedata/notebook_hackathons) if applicable.
  • New and existing unit and functional tests pass locally with my changes (make up-test && make test-run)

@eecavanna eecavanna merged commit 14d8ded into main Oct 31, 2024
2 checks passed
@eecavanna eecavanna deleted the 672-migrations-update-notebook-to-omit-mongo-credentials-from-commands-when-authentication-disabled branch October 31, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant