Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update queries:run examples #735

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Update queries:run examples #735

merged 2 commits into from
Oct 21, 2024

Conversation

aclum
Copy link
Contributor

@aclum aclum commented Oct 17, 2024

Description

This PR updates the examples for queries:run to use valid nmdc identifiers and replaces part_of with associated_studies to be compliant with the berkeley schema rollout.

Fixes #734

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration, if it is not simply make up-test && make test-run.

  • Test A
  • Test B

Configuration Details: none

Definition of Done (DoD) Checklist:

A simple checklist of necessary activities that add verifiable/demonstrable value to the product by asserting the quality of a feature, not the functionality of that feature; the latter should be stated as acceptance criteria in the issue this PR closes. Not all activities in the PR template will be applicable to each feature since the definition of done is intended to be a comprehensive checklist. Consciously decide the applicability of value-added activities on a feature-by-feature basis.

  • My code follows the style guidelines of this project (have you run black nmdc_runtime/?)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (in docs/ and in https://github.com/microbiomedata/NMDC_documentation/?)
  • I have added tests that prove my fix is effective or that my feature works, incl. considering downstream usage (e.g. https://github.com/microbiomedata/notebook_hackathons) if applicable.
  • New and existing unit and functional tests pass locally with my changes (make up-test && make test-run)

Update queries:run examples
@aclum aclum linked an issue Oct 17, 2024 that may be closed by this pull request
update to nmdc study identifier example.
@aclum aclum marked this pull request as ready for review October 17, 2024 23:12
@eecavanna
Copy link
Collaborator

And thank you for taking the initiative to fix things like this as you encounter them! I think all future "encounter-ers" will benefit from you having taken that initiative.

@aclum aclum merged commit 45613c1 into main Oct 21, 2024
2 checks passed
@aclum aclum deleted the 734-stale-queriesrun-examples branch October 21, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stale queries:run examples
3 participants