Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(style): use nmdc favicon #493

Merged
merged 1 commit into from
Mar 8, 2024
Merged

feat(style): use nmdc favicon #493

merged 1 commit into from
Mar 8, 2024

Conversation

dwinston
Copy link
Collaborator

@dwinston dwinston commented Mar 8, 2024

close #476

Description

Simply adds a new favicon.

@dwinston dwinston requested a review from eecavanna March 8, 2024 15:12
eecavanna
eecavanna approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me.

Caveats: I haven't tested the changes or looked at the favicon image (I'm in the mobile app and it won't display the binary file). I'm OOO today.

@dwinston dwinston merged commit bd786e7 into main Mar 8, 2024
2 checks passed
@dwinston dwinston deleted the 476-add-favicon branch March 8, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eecavanna eecavanna eecavanna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Branding: Swagger UI favicon is FastAPI logo (not NMDC logo)
2 participants
@dwinston @eecavanna