Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

478 refactor v1 workflows activities endpoint #479

Merged
merged 9 commits into from
Feb 14, 2024

Conversation

PeopleMakeCulture
Copy link
Collaborator

@PeopleMakeCulture PeopleMakeCulture commented Feb 14, 2024

Description

Fixes #478

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • introduces NEW workflows/activities endpoint that duplicates the functionality of the above
  • This change requires a documentation update
  • Add "Deprecated" note to v1
  • Add workflows/activities documentation

How Has This Been Tested?

Used example in #478 for added test_submit_workflow_activities test.

Checklist:

  • My code follows the style guidelines of this project (have you run black nmdc_runtime/?)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (in docs/ and in https://github.com/microbiomedata/NMDC_documentation/?) no need; this is a fix
  • I have added tests that prove my fix is effective or that my feature works, incl. considering downstream usage (e.g. https://github.com/microbiomedata/notebook_hackathons) if applicable.
  • New and existing unit and functional tests pass locally with my changes (make up-test && make test-run)

@PeopleMakeCulture PeopleMakeCulture changed the title 478 refactor v1 workflows activities endpoint **DRAFT DO NOT MERGE** 478 refactor v1 workflows activities endpoint Feb 14, 2024
@PeopleMakeCulture PeopleMakeCulture changed the title **DRAFT DO NOT MERGE** 478 refactor v1 workflows activities endpoint 478 refactor v1 workflows activities endpoint Feb 14, 2024
dwinston
dwinston previously approved these changes Feb 14, 2024
Copy link
Collaborator

@dwinston dwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will touch up a couple things (noted in review) that aren't blocking.

nmdc_runtime/api/endpoints/workflows.py Show resolved Hide resolved
nmdc_runtime/api/endpoints/workflows.py Show resolved Hide resolved

Parameters
"""
**NOTE: This endpoint is DEPRECATED. Please migrate to `~/workflows/activities`.**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the leading ~? I'll change to POST /workflows/activities.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not PR-blocking

status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
detail=str(rv),
)
# create mongodb instance for dagster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more accurately, use same logic as the dagster job for json:submit endpoint.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not PR-blocking

Copy link
Collaborator

@dwinston dwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added test

@dwinston dwinston merged commit 85ebb1e into main Feb 14, 2024
2 checks passed
@PeopleMakeCulture PeopleMakeCulture deleted the 478-refactor-v1-workflows-activities-endpoint branch September 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/v1/workflows/activities endpoint adds empty keys with null values to mongo
2 participants