-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
478 refactor v1 workflows activities endpoint #479
Conversation
Merge addtnl comments
…://github.com/microbiomedata/nmdc-runtime into 478-refactor-v1-workflows-activities-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will touch up a couple things (noted in review) that aren't blocking.
|
||
Parameters | ||
""" | ||
**NOTE: This endpoint is DEPRECATED. Please migrate to `~/workflows/activities`.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the leading ~
? I'll change to POST /workflows/activities
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not PR-blocking
status_code=status.HTTP_422_UNPROCESSABLE_ENTITY, | ||
detail=str(rv), | ||
) | ||
# create mongodb instance for dagster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more accurately, use same logic as the dagster job for json:submit
endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not PR-blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added test
Description
Fixes #478
Type of change
How Has This Been Tested?
Used example in #478 for added
test_submit_workflow_activities
test.Checklist:
black nmdc_runtime/
?)docs/
and in https://github.com/microbiomedata/NMDC_documentation/?) no need; this is a fixmake up-test && make test-run
)