Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

301-part-1-skip-pytest-failures #463

Merged
merged 10 commits into from
Jan 31, 2024
Merged

Conversation

PeopleMakeCulture
Copy link
Collaborator

@PeopleMakeCulture PeopleMakeCulture commented Jan 31, 2024

This PR skips all currently failing tests in order to restore the github action that runs automated tests for each PR
Related to: #301

image
image

@eecavanna eecavanna self-requested a review January 31, 2024 21:12
eecavanna
eecavanna previously approved these changes Jan 31, 2024
Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OOO today.

The changes look good to me.

dwinston
dwinston previously approved these changes Jan 31, 2024
Copy link
Collaborator

@dwinston dwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

pkalita-lbl
pkalita-lbl previously approved these changes Jan 31, 2024
dwinston
dwinston previously approved these changes Jan 31, 2024
@PeopleMakeCulture
Copy link
Collaborator Author

Made one change to test.Dockerfile to force GH Action to fail after first failed test

@PeopleMakeCulture PeopleMakeCulture merged commit f44f9ee into main Jan 31, 2024
2 checks passed
@PeopleMakeCulture PeopleMakeCulture deleted the 301-fix-pytest-failures branch January 31, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants