Revert to using env context for variables #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkalita-lbl
changed the title
eecavanna
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
LGTM!
To me, this approach seems consistent with an example I saw in the GitHub docs earlier:
https://docs.github.com/en/actions/learn-github-actions/expressions#example
|
Notes about error messages in the GHA logs:
The errors for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #390.
I thought I understood the GitHub workflows environment file thing, but oops not quite. I think those values are only sent to the runners so they can't be used for things like
enable=${{ env.IS_PROD_RELEASE }}outside ofrunin astep. So, back to using a workflow-levelenvblock.