Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: de-duplicate metadata submission after one minute #347

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

dwinston
Copy link
Collaborator

@dwinston dwinston commented Nov 2, 2023

re-submission of "same" changes is a valid use case

closes #340

re-submission of "same" changes is a valid use case

closes #340
Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is to guarantee that the base value changes at least once per minute. I don't know the context here, but the code change looks straightforward to me. Approved!

@eecavanna
Copy link
Collaborator

I recommend holding off on merging this until there is no risk of such a merge complicating the resolution of issue #348.

@dwinston dwinston merged commit 21393c5 into main Nov 2, 2023
dwinston added a commit that referenced this pull request Nov 3, 2023
re-submission of "same" changes is a valid use case

closes #340
@PeopleMakeCulture PeopleMakeCulture deleted the 340-deduplicate-after-1min branch November 13, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksum Matches Existing Object - Json submit endpoint
3 participants