Changesheet validator returns HTTP 200 response even when reporting write errors

[eecavanna]

API endpoint URL: https://api-dev.microbiomedata.org/metadata/changesheets:validate

Example problematic changesheet:

id	action	attribute	value
nmdc:bsm-11-kyjye260	insert	gold_biosample_identifiers	gold:Gb0255534

Corresponding HTTP response body (excerpt):

        "writeErrors": [
          {
            "index": 0,
            "code": 14,
            "errmsg": "The argument to $each in $addToSet must be an array but it was of type string"
          }
        ],

Screenshot:

I expected the endpoint to return an HTTP 422 instead of an HTTP 200.

[aclum]

FYI @dwinston @eecavanna @shreddd adding this to the sprint for next week as this is a high priority issue to get fixed. cc @sujaypatil96 @mbthornton-lbl

[dwinston]

returns 422 response with code fix. will link to PR.

{
  "detail": {
    "update_cmd": {
      "nmdc:bsm-11-kyjye260": {
        "update": "biosample_set",
        "updates": [
          {
            "q": {
              "id": "nmdc:bsm-11-kyjye260"
            },
            "u": {
              "$addToSet": {
                "gold_biosample_identifiers": {
                  "$each": "gold:Gb0255534"
                }
              }
            }
          }
        ]
      }
    },
    "validation_errors": [
      [
        {
          "index": 0,
          "code": 14,
          "errmsg": "The argument to $each in $addToSet must be an array but it was of type string"
        }
      ]
    ]
  }
}