Skip to content

Commit

Permalink
clarify definition of harcoded text 'eEnvironment'
Browse files Browse the repository at this point in the history
  • Loading branch information
sujaypatil96 committed Jun 24, 2024
1 parent e82780f commit b9c6d38
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions nmdc_runtime/site/export/ncbi_xml.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ def set_bioproject(self, title, project_id, description, data_type, org):

descriptor = self.set_descriptor(title, description)
project_type = self.set_element("ProjectType")
# "sample_scope" is a enumeration feild. Docs: https://www.ncbi.nlm.nih.gov/data_specs/schema/other/bioproject/Core.xsd
# scope is "eEnvironment" when "Content of species in a sample is not known, i.e. microbiome,metagenome, etc.."
project_type_submission = self.set_element(
"ProjectTypeSubmission", attrib={"sample_scope": "eEnvironment"}
)
Expand Down Expand Up @@ -422,10 +424,10 @@ def get_submission_xml(
# submission_xsd_url = "https://www.ncbi.nlm.nih.gov/viewvc/v1/trunk/submit/public-docs/common/submission.xsd?view=co"
# validate_xml(submission_xml, submission_xsd_url)

# bioproject_xsd_url = "https://www.ncbi.nlm.nih.gov/viewvc/v1/trunk/submit/public-docs/common/bioproject.xsd?view=co"
# bioproject_xsd_url = "https://www.ncbi.nlm.nih.gov/viewvc/v1/trunk/submit/public-docs/bioproject/bioproject.xsd?view=co"
# validate_xml(submission_xml, bioproject_xsd_url)

# biosample_xsd_url = "https://www.ncbi.nlm.nih.gov/viewvc/v1/trunk/submit/public-docs/common/biosample.xsd?view=co"
# biosample_xsd_url = "https://www.ncbi.nlm.nih.gov/viewvc/v1/trunk/submit/public-docs/biosample/biosample.xsd?view=co"
# validate_xml(submission_xml, biosample_xsd_url)

return submission_xml

0 comments on commit b9c6d38

Please sign in to comment.