Merge pull request #660 from microbiomedata/470-missing-attribute-qua…

…litycontrolreport-causing-multiple-neon-tests-to-fail 470 missing attribute qualitycontrolreport causing multiple neon tests to fail
microbiomedata · Aug 29, 2024 · ac6cf8a · ac6cf8a
2 parents 7955875 + 03726e5
commit ac6cf8a
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/nmdc_runtime/site/translation/neon_benthic_translator.py b/nmdc_runtime/site/translation/neon_benthic_translator.py
@@ -185,9 +185,7 @@ def _translate_extraction_process(
             input_mass=_create_quantity_value(
                 _get_value_or_none(extraction_row, "sampleMass"), "g"
             ),
-            quality_control_report=nmdc.QualityControlReport(
-                status=_get_value_or_none(extraction_row, "qaqcStatus")
-            ),
+            qc_status=_get_value_or_none(extraction_row, "qaqcStatus"),
             processing_institution=processing_institution,
         )
 

diff --git a/nmdc_runtime/site/translation/neon_soil_translator.py b/nmdc_runtime/site/translation/neon_soil_translator.py
@@ -280,9 +280,7 @@ def _translate_extraction_process(
             input_mass=_create_quantity_value(
                 _get_value_or_none(extraction_row, "sampleMass"), "g"
             ),
-            quality_control_report=nmdc.QualityControlReport(
-                status=_get_value_or_none(extraction_row, "qaqcStatus")
-            ),
+            qc_status=_get_value_or_none(extraction_row, "qaqcStatus"),
             processing_institution=processing_institution,
         )
 

diff --git a/tests/test_data/test_neon_benthic_data_translator.py b/tests/test_data/test_neon_benthic_data_translator.py
@@ -157,7 +157,6 @@ def translator(self, test_minter):
                                          id_minter=test_minter
                                         )
 
-    @pytest.mark.xfail(reason="AttributeError: module 'nmdc_schema.nmdc' has no attribute 'QualityControlReport'")
     def test_get_database(self, translator):
         database = translator.get_database()
 

diff --git a/tests/test_data/test_neon_soil_data_translator.py b/tests/test_data/test_neon_soil_data_translator.py
@@ -860,7 +860,6 @@ def test_create_timestamp_value_with_valid_args(self):
         collect_date = _create_timestamp_value("2020-07-13T14:34Z")
         assert collect_date.has_raw_value == "2020-07-13T14:34Z"
 
-    @pytest.mark.xfail(reason="AttributeError: module 'nmdc_schema.nmdc' has no attribute 'QualityControlReport'")
     def test_get_database(self, translator):
         database = translator.get_database()