Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regenerate #17

Merged
merged 1 commit into from
Feb 14, 2024
Merged

regenerate #17

merged 1 commit into from
Feb 14, 2024

Conversation

turbomam
Copy link
Member

@turbomam turbomam commented Feb 7, 2024

@turbomam turbomam linked an issue Feb 7, 2024 that may be closed by this pull request
regenerate new ontology files, but stick to relation-graph v1.2 #16
Closed
@turbomam turbomam requested review from cmungall and aclum February 7, 2024 16:13
aclum
aclum requested changes Feb 10, 2024
View reviewed changes
Copy link

@aclum aclum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find some of new envo terms in in the nmdco-classes.json. 'stream water' ENVO:03605006 or 'freshwater stream biome' ENVO:03605008. Are those expected in the json or I'm looking at the wrong file.

@turbomam
Copy link
Member Author

turbomam commented Feb 14, 2024 •
edited
Loading

I can't find some of new envo terms in in the nmdco-classes.json. 'stream water' ENVO:03605006 or 'freshwater stream biome' ENVO:03605008. Are those expected in the json or I'm looking at the wrong file.

Thanks @aclum. I'm going to merge this and make a release, and watch to see if Bioportal updates their records.

Then I'll separately start another PR and make sure that "our" new EnvO terms get in this artifact. You were looking at the most relevant files.

@turbomam turbomam merged commit 8041c34 into main Feb 14, 2024
1 check passed
@turbomam turbomam deleted the 16-regenerate-new-ontology-files-but-stick-to-relation-graph-v12 branch February 14, 2024 20:04
turbomam added a commit that referenced this pull request Feb 14, 2024
@turbomam
Merge pull request #17 from microbiomedata/16-regenerate-new-ontology…
c549fce 
…-files-but-stick-to-relation-graph-v12

regenerate
@turbomam
Copy link
Member Author

@aclum "stream water" is in nmdco-classes.json now

@turbomam
Copy link
Member Author

turbomam commented Feb 15, 2024 •
edited
Loading

I have also added some QC reports https://github.com/microbiomedata/nmdc-ontology/tree/main/data-vs-ontology-reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclum aclum aclum requested changes

@cmungall cmungall Awaiting requested review from cmungall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regenerate new ontology files, but stick to relation-graph v1.2
2 participants
@turbomam @aclum