Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 12: remove equivalents as subclasses #13

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Issue 12: remove equivalents as subclasses #13

merged 4 commits into from
Aug 25, 2021

Conversation

wdduncan
Copy link
Contributor

Fixes #12
The nmco-classes.json file had equivalent classes as subclasses of each other (i.e., X is_a Y and Y is_a X).

This is confusing for consumers of the data. These subclass statements have been removed for equivalent classes. Equivalent class information is now in the equivalentNodesSets section of the file. E.g.:

"equivalentNodesSets" : [ {
      "nodeIds" : [ "http://purl.obolibrary.org/obo/ENVO_01001784", "http://purl.obolibrary.org/obo/ENVO_01001479" ]
    }, {
      "nodeIds" : [ "http://purl.obolibrary.org/obo/FOODON_00001100", "http://purl.obolibrary.org/obo/FOODON_03301103" ]
    }, {
      "nodeIds" : [ "http://purl.obolibrary.org/obo/FOODON_03460231", "http://purl.obolibrary.org/obo/FOODON_03460229" ]
    } ]

@wdduncan wdduncan merged commit 8d9dfbd into main Aug 25, 2021
@wdduncan wdduncan deleted the issue-12 branch August 25, 2021 03:44
turbomam pushed a commit that referenced this pull request Feb 14, 2024
Issue 12: remove equivalents as subclasses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove inferred equivalences
1 participant