Check any_of on slot definition when determining input type
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176
These changes update the helper method (
getSelectState) insrc/components/SampleSlotEditModal/SampleSlotEditModal.tsxwhich determines whether to show a select box or a plain text box for a given slot. Previously the logic only looked at the slot'srange. That's sufficient most of the time, but there are a few slots that (mainly for historical reasons) allow either a string or an enum (via theany_ofslot attribute). PreviouslygetSelectStatewould returnisSelectable: falsein that case. Now it will returnisSelectable: trueand the appropriate permissible values.