Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotation update to 5.3 -genomad #36

Open
Tracked by #249
aclum opened this issue Sep 16, 2024 · 10 comments
Open
Tracked by #249

annotation update to 5.3 -genomad #36

aclum opened this issue Sep 16, 2024 · 10 comments
Assignees

Comments

@aclum
Copy link
Collaborator

aclum commented Sep 16, 2024

In October JGI is updating to annotation 5.3
to sync with that we need to add a WLD for genomad that gets run as part of annotation pipeline.

Recommend setting this up as a separate WDL, having that WDL be imported to full_annotation.wdl

WDL task to wrap genomad.sh
https://code.jgi.doe.gov/img/img-pipelines/img-annotation-pipeline/-/blob/5.3/bin/genomad/genomad.sh?ref_type=heads

Program and DB file will need to be added to the info file.

There should be a boolean flag to execute this.

@ssarrafan
Copy link

@aclum @kaijli doesn't appear to be actively worked on. Can this be backlogged? Or moved to next sprint?

@aclum
Copy link
Collaborator Author

aclum commented Oct 4, 2024

Kaitlyn is out until the 14, backlogging we address missing key issues in the handoff b/w workflows and nmdc_automation, microbiomedata/issues#898

@kaijli
Copy link
Contributor

kaijli commented Oct 29, 2024

Need values for the following inputs:

        String db_dir                # this is most important one that I don't think I can find
        String container_run_cmd     # I'll see if I can find something in the repo
        Int threads = 1              # this is listed as 64 threads in the example 

I might not need to use the container_run_cmd if i follow this script https://code.jgi.doe.gov/img/img-pipelines/img-annotation-pipeline/-/blob/5.3/bin/annotate.sh?ref_type=heads#L171-174

Upon basic testing, if the img-omics image that we use in mg_annotation is updated to contain the genomad script, it would be much nicer than having to call the container_run_cmd

@kaijli
Copy link
Contributor

kaijli commented Nov 1, 2024

Figured out container issue, working on getting a container that jaws can see and have a test run started

@ssarrafan
Copy link

Is this still actively being worked on @kaijli ? I don't see any updates in 2 weeks so will remove from board and add the backlog label unless you let me know it's active.

FYI @aclum

@aclum
Copy link
Collaborator Author

aclum commented Nov 15, 2024

Actively in progress, we need to debug some permission issues.

@ssarrafan
Copy link

@aclum @kaijli still actively being worked on?

@aclum
Copy link
Collaborator Author

aclum commented Dec 3, 2024

Yes, we have a new docker image from Marcel which was built and pushed to dockerhub today and @kaijli is running tests now.

@aclum
Copy link
Collaborator Author

aclum commented Dec 13, 2024

this is active, moving to the next sprint.

@ssarrafan
Copy link

@kaijli will leave this on this board since you're working this week. If you need help moving it to the next sprint ping me. Happy holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants