Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythonic improvements #4

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Pythonic improvements #4

merged 5 commits into from
Sep 26, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

These changes address some minor performance and maintainability concerns.

  • Move duplicated code in GeoEngine into private static methods.
  • Use a @cache'd function to read CSV files so that they aren't read more than once and provide them as @property's on GeoEngine
  • Rename various variables to follow standard naming conventions
  • Use funcional-style testing
  • Allow importing GeoEngine from top-level nmdc_geoloc_tools package

@pkalita-lbl pkalita-lbl merged commit 940ba83 into main Sep 26, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the pythonic-improvements branch September 26, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant