Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32 updating logic for reads qc #36

Merged
merged 8 commits into from
Aug 23, 2024
Merged

#32 updating logic for reads qc #36

merged 8 commits into from
Aug 23, 2024

Conversation

vlilanl
Copy link
Contributor

@vlilanl vlilanl commented Aug 7, 2024

I updated the input.json so that if there are multiple already interleaved files, they go into rqcfilter.input_files. If the files are not interleaved, Read 1 will be placed in rqcfilter.input_fq1 and Read 2 will be placed in rqcfilter.input_fq2. I have also added a boolean to say whether or not the files are interleaved.

This was tested on JAWS.
Interleaved test of 1 : 83296
Interleaved test of 2 : 83295
Not interleaved test of 2 files(1 interleaved file) : 83439
Not interleaved test of 4 files(2 interleaved files) : 83447

@vlilanl vlilanl requested a review from aclum August 7, 2024 20:01
@vlilanl vlilanl linked an issue Aug 7, 2024 that may be closed by this pull request
@aclum
Copy link
Contributor

aclum commented Aug 8, 2024

@vlilanl at least 83296 doesnt appear to correctly run the finish_rqc to generate the final files.

@vlilanl
Copy link
Contributor Author

vlilanl commented Aug 14, 2024

New tests on jaws:
Interleaved test of 1 : 83868
Interleaved test of 2 : 83870
Not interleaved test of 2 files(1 interleaved file) : 83942
Not interleaved test of 4 files(2 interleaved files) : 83943

@kaijli mentioned that there might be potential memory risks later on especially if the input files are large. She recommends that we update the memory to how she did it in metat.

@vlilanl
Copy link
Contributor Author

vlilanl commented Aug 20, 2024

Jaws test for increased memory: 84325

@vlilanl vlilanl requested a review from kaijli August 20, 2024 19:30
shortReadsqc.wdl Outdated Show resolved Hide resolved
@vlilanl vlilanl linked an issue Aug 23, 2024 that may be closed by this pull request
@vlilanl vlilanl merged commit d0915ae into master Aug 23, 2024
1 check passed
@vlilanl vlilanl deleted the 32-update-logic branch August 23, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants