Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR: Document decision to provide data migration scripts alongside schema changes #24

Merged
merged 2 commits into from
Aug 1, 2023
Merged

ADR: Document decision to provide data migration scripts alongside schema changes #24

merged 2 commits into from
Aug 1, 2023

Conversation

eecavanna
Copy link
Contributor

@eecavanna eecavanna commented Aug 1, 2023 •
edited
Loading

Here's a link to the rendered preview of this document:
https://github.com/microbiomedata/NMDC_documentation/blob/eecavanna-decisions-0007-mongo-migration-scripts/decisions/0007-mongo-migration-scripts.md

To do:

  • Draft ADR
  • Populate consulted field
  • Confirm all deciders are OK with the "Decision Outcome" shown

@eecavanna eecavanna added the documentation Improvements or additions to documentation label Aug 1, 2023
@eecavanna eecavanna self-assigned this Aug 1, 2023
@eecavanna eecavanna mentioned this pull request Aug 1, 2023
Closed
5 tasks
shreddd
shreddd approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@shreddd shreddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - to approve - you can leave consulted blank since everyone was in the deciding team

@eecavanna eecavanna marked this pull request as ready for review August 1, 2023 22:21
@eecavanna
Copy link
Contributor Author

eecavanna commented Aug 1, 2023 •
edited
Loading

The check-links job is failing on GitHub Actions. I created an issue about it, here: #25

Since it is failing even on the main branch (independently of this PR branch), I won't hold up the merging of this PR branch for it.

@eecavanna eecavanna merged commit fed2372 into main Aug 1, 2023
@eecavanna eecavanna deleted the eecavanna-decisions-0007-mongo-migration-scripts branch August 1, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddd shreddd shreddd approved these changes

Assignees

@eecavanna eecavanna

Labels
documentation Improvements or additions to documentation
Projects
No open projects
2023 Squad Sprint 16: July 31 - August 11, 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eecavanna @shreddd