Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

All "MIxS required where applicable" terms should be highlighted purple (recommended) #151

Closed
pvangay opened this issue Feb 9, 2022 · 3 comments
Assignees
Labels
bug Something isn't working minimal modification method req as opposed to all-or-nothing as-is vs static 'MIxS modified' etc. schemasheets possible replacement for Soil-NMDC-Template_Compiled sections

Comments

@pvangay
Copy link

pvangay commented Feb 9, 2022

Based on my understanding of "required where applicable", I would expect these terms to be highlighted in purple to indicate that they are recommended terms.

image

@pvangay pvangay added the bug Something isn't working label Feb 9, 2022
@turbomam
Copy link
Member

turbomam commented Feb 9, 2022

Agreed.

If a term is taken from MIxs or NMDC as-is, that authority determines whether the corresponding column is recommended or required. That's completely independent of which DH section it is assigned to.

When there's a MIxS term in a recommended or required Section with the wrong color (and therefore the wrong validation rule), the current alternatives are:

  • statically remodel all attributes of the term, including revised recommended and required flags, in the MIxS modified tab. That static remodelling runs the risk of getting out of sync with the living MIxS standard.
  • petition GSC to change the requirement status in the MIxS standard and wait for their response
  • I have been meaning to implement a minimal-modification strategy as part of moving from the existing SNTC Google sheet to the schemasheets standard, but I don't see how that could be completed in the next week or two.

I think therese some additional documentation and discussion about this out there. I'll try to link it in tomorrow.

See also #150

@turbomam turbomam added minimal modification method req as opposed to all-or-nothing as-is vs static 'MIxS modified' etc. sections schemasheets possible replacement for Soil-NMDC-Template_Compiled labels Feb 10, 2022
@pvangay
Copy link
Author

pvangay commented Feb 10, 2022

After reading this, I believe I am uninformed about the logic that determines when terms are labeled with "recommended".

These are how terms are labeled with checklist requirements from MIxS:

  • mandatory (M)
  • conditional mandatory (C)
  • optional (X)
  • environment-dependent (E)
  • not applicable (-)

Is our section "MIxS required where applicable" equivalent to terms marked "conditional mandatory (C)" in MIxS?

It looks like there are no as-is MIxS terms marked "recommended" so perhaps that means that there is no mapping between DH's "recommended" and MIxS's checklist requirement categories. I'd like to understand this better.

@pkalita-lbl
Copy link
Collaborator

I don't know if there is any specific actionable item here. If any specific slot needs have its recommended or required status changed, please open an issues in the submission-schema repo. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working minimal modification method req as opposed to all-or-nothing as-is vs static 'MIxS modified' etc. schemasheets possible replacement for Soil-NMDC-Template_Compiled sections
Projects
None yet
Development

No branches or pull requests

3 participants