Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

All MIxS required terms should be required and highlighted yellow #150

Closed
pvangay opened this issue Feb 9, 2022 · 3 comments
Closed

All MIxS required terms should be required and highlighted yellow #150

pvangay opened this issue Feb 9, 2022 · 3 comments
Assignees
@turbomam
Labels
bug Something isn't working GSP2023 Add to any issue related to GSP 2023 goals minimal modification method req as opposed to all-or-nothing as-is vs static 'MIxS modified' etc. sections

Comments

@pvangay
Copy link

pvangay commented Feb 9, 2022 •
edited
Loading

According to MIxS, these terms should be required:

  • Geographic location
  • Geographic location (latitude and longitude)

In the interface, they currently are not highlighted yellow nor required (validates successfully if these cells are empty)
image
@pvangay pvangay added the bug Something isn't working label Feb 9, 2022
@turbomam turbomam mentioned this issue Feb 9, 2022
Closed
@turbomam
Copy link
Member

turbomam commented Feb 9, 2022 •
edited
Loading

Agreed. Solution may be complex. See #151

@turbomam turbomam added minimal modification method req as opposed to all-or-nothing as-is vs static 'MIxS modified' etc. sections labels Feb 10, 2022
@pvangay pvangay added the GSP2023 Add to any issue related to GSP 2023 goals label Feb 10, 2022
@pvangay
Copy link
Author

pvangay commented Feb 22, 2022

In the latest version of https://data.dev.microbiomedata.org/submission/samples

Geographic location and Geographic location (latitude and longitude) moved from MIxS to Mixs modified. I dont understand why. @turbomam

@turbomam turbomam mentioned this issue Feb 24, 2022
Closed
1 task
@mslarae13 mslarae13 mentioned this issue Jan 18, 2023
Open
99 tasks
@pkalita-lbl
Copy link
Collaborator

This is fixed now. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@turbomam turbomam

Labels
bug Something isn't working GSP2023 Add to any issue related to GSP 2023 goals minimal modification method req as opposed to all-or-nothing as-is vs static 'MIxS modified' etc. sections
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pvangay @turbomam @pkalita-lbl