Update topic memory approach #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
julionce
reviewed
Jun 11, 2020
julionce
reviewed
Jun 11, 2020
jamoralp
approved these changes
Jul 1, 2020
pablogs9
added a commit
that referenced
this pull request
Jul 21, 2020
* rmw_get_client_names_and_types_by_node function * rmw_get_*_info_by_topic function * Loaned message interface * API renamings * Fix typo * RMW_RET_ERROR to RMW_RET_UNSUPPORTED fx * rmw_*_event_init function * rmw_get_node_names_with_enclaves function * rmw_take_sequence function * Topic workaround * XML publisher/subscriber workaround * Disable testing workaround * Fix session lookup (#67) * RMW wait function fix * Refactor guard condition * rmw_take_sequence() implementation (#66) * Implement rmw_take_sequence * Fix unused variable * Fix sequence errors * Fix take with info * Fix tests (#64) * Update topic memory approach (#65) * Update topic memory approach * Fix naming * Added RMW_UXRCE_MAX_TOPICS = -1 explanation * Adding enclave (#68) * Fix warnings (#69) * Fix warnings * Fix warnings * Fix unintialized * Guard Header * Fix TODOs * Fix TODOs * Trailing whitespaces * End new line * Comma space * Else new line * Buffer lenght * Redundant blank lines * Redundant blank lines * CMake lint * Uncrustify * Uncrustify * Uncrustify * Uncrustify * Assert to Expect GTest * Updates * Fix topic define redefinition * Updates * Passing test * Uncrustify * Uncrustify * Updated pubsub test * Added CI * Comment * CMake style Co-authored-by: Your Name <[email protected]> * Fix CI * Disabling clang-tidy * Move XML/ref buffers to static * Fix uninitialized value * Update CI * Added termios includes to rmw_init Co-authored-by: Your Name <[email protected]> Co-authored-by: Jose Antonio Moral <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the management of topic memory in the rmw_microxrcedds to align with the static pools of the other entities.