forked from ethereum/execution-apis
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7547 engine API changes #1
Open
michaelneuder
wants to merge
21
commits into
main
Choose a base branch
from
eip-7547
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5c0ddea
init commit
michaelneuder bf1ad6a
v1
michaelneuder 2e3a103
Update src/engine/eip7547.md
michaelneuder bdfaab6
Update src/engine/eip7547.md
michaelneuder 579ee4e
Update src/engine/eip7547.md
michaelneuder 4b198f3
reviews
michaelneuder 0b98a1b
Merge branch 'eip-7547' of https://github.com/michaelneuder/execution…
michaelneuder f7a8d0e
small tweaks
michaelneuder 66c9853
Add IL to newPayload, remove from PayloadAttributes
fradamt c99a990
Merge pull request #2 from fradamt/eip-7547
michaelneuder e62201b
engine updates
michaelneuder 1b437eb
merge fix
michaelneuder a58e3b2
doctoc .
michaelneuder cb804fb
Update src/engine/experimental/eip7547.md
michaelneuder 9466cc4
updates
michaelneuder c9d90d2
updates based on marius and other feedback
michaelneuder 233aed6
doctoc .
michaelneuder da31d81
add parent block hash
michaelneuder fb28462
remove Entry
michaelneuder 93881a5
add config param
michaelneuder f17f3d8
update engine
michaelneuder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
# Engine API -- EIP7547 | ||
|
||
Engine API changes introduced in EIP7547. | ||
|
||
This specification is based on and extends [Engine API - Cancun](./cancun.md) specification. | ||
|
||
## Table of contents | ||
|
||
<!-- START doctoc generated TOC please keep comment here to allow auto update --> | ||
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> | ||
|
||
- [Constants](#constants) | ||
- [Structures](#structures) | ||
- [InclusionListSummaryEntryV1](#inclusionlistsummaryentryv1) | ||
- [InclusionListSummaryV1](#inclusionlistsummaryv1) | ||
- [InclusionListStatusV1](#inclusionliststatusv1) | ||
- [Methods](#methods) | ||
- [engine_newInclusionListV1](#engine_newinclusionlistv1) | ||
- [Request](#request) | ||
- [Response](#response) | ||
- [Specification](#specification) | ||
- [engine_getInclusionListV1](#engine_getinclusionlistv1) | ||
- [Request](#request-1) | ||
- [Response](#response-1) | ||
- [Specification](#specification-1) | ||
|
||
<!-- END doctoc generated TOC please keep comment here to allow auto update --> | ||
|
||
## Constants | ||
|
||
| Name | Value | | ||
| - | - | | ||
| `INCLUSION_LIST_MAX_GAS` | `uint64(4194304) = 2**22` | | ||
|
||
## Structures | ||
|
||
### InclusionListSummaryEntryV1 | ||
|
||
This structure contains the details of each inclusion list entry. | ||
|
||
- `address` : `DATA`, 20 Bytes | ||
- `nonce` : `QUANTITY`, 64 Bits | ||
|
||
### InclusionListSummaryV1 | ||
|
||
This structure contains the inclusion list summary. | ||
|
||
- `slot` : `QUANTITY`, 64 Bits | ||
- `proposer_index`: `QUANTITY`, 64 Bits | ||
- `parent_hash`: `DATA`, 32 Bytes | ||
- `summary`: `Array of InclusionListSummaryEntryV1`, Array of entries that must be satisfied. | ||
|
||
### InclusionListStatusV1 | ||
|
||
This structure contains the result of processing an inclusion list. The fields are encoded as follows: | ||
|
||
- `status`: `enum` - `"VALID" | "INVALID" | "SYNCING" | "ACCEPTED"` | ||
- `validationError`: `String|null` - a message providing additional details on the validation error if the payload is classified as `INVALID`. | ||
|
||
## Methods | ||
|
||
### engine_newInclusionListV1 | ||
|
||
#### Request | ||
|
||
* method: `engine_newInclusionListV1` | ||
* params: | ||
1. `inclusionListSummary`: `InclusionListSummaryV1` - Summary. | ||
2. `inclusionListTransactions`: `Array of DATA` - Array of transaction objects, each object is a byte list (`DATA`) representing `TransactionType || TransactionPayload` or `LegacyTransaction` as defined in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718) | ||
* timeout: 1s | ||
|
||
#### Response | ||
|
||
* result: [`InclusionListStatusV1`](./#inclusionliststatusv1). | ||
* error: code and message set in case an exception happens while processing the inclusion list. | ||
|
||
#### Specification | ||
|
||
1. Client software **MUST** validate the inclusion list transactions are valid (correct nonce and sufficient base fee) given the parent block hash specified. If the parent block is not available, return false. | ||
2. Client software **MUST** validate that the sum of inclusion list transactions gas does not exceed `INCLUSION_LIST_MAX_GAS`. | ||
3. Client software **MUST** validate that the summary and transactions are the same length. | ||
4. Client software **MUST** validate that the order of the summary entries matches the order of the transactions. | ||
|
||
### engine_getInclusionListV1 | ||
|
||
#### Request | ||
|
||
* method: `engine_getInclusionListV1` | ||
* timeout: 1s | ||
|
||
#### Response | ||
|
||
* result: `object` | ||
- `inclusionListSummary`: `InclusionListSummaryV1` - Summary. | ||
- `inclusionListTransactions`: `Array of DATA` - Array of transaction objects, each object is a byte list (`DATA`) representing `TransactionType || TransactionPayload` or `LegacyTransaction` as defined in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718) | ||
* error: code and message set in case an exception happens while getting the inclusion list. | ||
|
||
#### Specification | ||
|
||
1. Client software **MUST** provide a list of transactions for the inclusion list based on local view of the mempool and according to the config specifications. | ||
2. Client software **MUST** broadcast their inclusion list in addition to the full beacon block during their block proposal. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super pedantic, but this could be a u32 right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it should be u64, since the gas limit is u64 as well (sure we won't exceed u32 anytime soon, but the spec should be consistent)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, makes sense