EIP-7547 engine API changes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
reviewed
Jan 31, 2024
shekhirin
reviewed
Jan 31, 2024
rkrasiuk
reviewed
Jan 31, 2024
rkrasiuk
reviewed
Jan 31, 2024
Co-authored-by: Roman Krasiuk <[email protected]>
Co-authored-by: Roman Krasiuk <[email protected]>
Co-authored-by: Roman Krasiuk <[email protected]>
small changes
Rjected
reviewed
Feb 7, 2024
Co-authored-by: Dan Cline <[email protected]>
3 tasks
Rjected
reviewed
Mar 21, 2024
|
|
||
| | Name | Value | | ||
| | - | - | | ||
| | `INCLUSION_LIST_MAX_GAS` | `uint64(4194304) = 2**22` | |
There was a problem hiding this comment.
super pedantic, but this could be a u32 right?
There was a problem hiding this comment.
No it should be u64, since the gas limit is u64 as well (sure we won't exceed u32 anytime soon, but the spec should be consistent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: Engine API changes to reflect new types and contain IL data.
Itemized:
INCLUSION_LIST_MAX_GASconstantInclusionListSummaryEntryV1InclusionListSummaryV1InclusionListStatusV1engine_newInclusionListV1(new API)engine_getInclusionListV1(new API)The sequence diagram below shows the block production flow, using each of the above APIs.