Fix Nelder-Mead init_simplex_corner creation
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in michaelhush#175, the way `self.init_simplex_corner` is created for `NelderMeadLearner` is problematic because it is set equal to `self.min_boundary`. This means that when `self.init_simplex_corner` is later modified, `self.min_boundary` is modified as well. This PR resolves the issue using the approach suggested in michaelhush#175, namely by assigning a copy of `self.min_boundary` to `self.init_simplex_corner` rather than assigning the original array itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #175, the way
self.init_simplex_corneris created forNelderMeadLearneris problematic because it is set equal toself.min_boundary. This means that whenself.init_simplex_corneris later modified,self.min_boundaryis modified as well. This PR resolves the issue using the approach suggested in #175, namely by assigning a copy ofself.min_boundarytoself.init_simplex_cornerrather than assigning the original array itself.