A typo in controllers.py #175
Comments
|
In addition, in learners.py: Line 576, I think a shallow copy "self.init_simplex_corner=copy.copy(self.min_boundary)" is expected. In this case, the update of self.init_simplex_corner in Line 578 will not affect "self.min_boundary". Otherwise, when simply using "self.init_simplex_corner=self.min_boundary", the value of min_boundary is changed with the update of "self.init_simplex_corner". |
zakv
added a commit
to zakv/M-LOOP
that referenced
this issue
Feb 25, 2024
As pointed out in michaelhush#175, the way `self.init_simplex_corner` is created for `NelderMeadLearner` is problematic because it is set equal to `self.min_boundary`. This means that when `self.init_simplex_corner` is later modified, `self.min_boundary` is modified as well. This PR resolves the issue using the approach suggested in michaelhush#175, namely by assigning a copy of `self.min_boundary` to `self.init_simplex_corner` rather than assigning the original array itself.
zakv
added a commit
that referenced
this issue
Feb 25, 2024
As pointed out in #175, the way `self.init_simplex_corner` is created for `NelderMeadLearner` is problematic because it is set equal to `self.min_boundary`. This means that when `self.init_simplex_corner` is later modified, `self.min_boundary` is modified as well. This PR resolves the issue using the approach suggested in #175, namely by assigning a copy of `self.min_boundary` to `self.init_simplex_corner` rather than assigning the original array itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there,
Thanks for your work.
In controllers.py, I find a typo on line 475 of controllers.py, which should be self.max_boundary.
The text was updated successfully, but these errors were encountered: