chore(NA): splits types from code on @kbn/securitysolution-list-api (e…

…lastic#121680) * chore(NA): splits types from code on @kbn/securitysolution-list-api * chore(NA): export type only * chore(NA): merge and solve conflicts wth main
mibragimov · Dec 22, 2021 · dfc2f61 · dfc2f61
1 parent 30c9a96
commit dfc2f61
Show file tree

Hide file tree

Showing 7 changed files with 38 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -588,6 +588,7 @@
     "@types/kbn__securitysolution-io-ts-alerting-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-alerting-types/npm_module_types",
     "@types/kbn__securitysolution-io-ts-list-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-list-types/npm_module_types",
     "@types/kbn__securitysolution-io-ts-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-types/npm_module_types",
+    "@types/kbn__securitysolution-list-api": "link:bazel-bin/packages/kbn-securitysolution-list-api/npm_module_types",
     "@types/license-checker": "15.0.0",
     "@types/listr": "^0.14.0",
     "@types/loader-utils": "^1.1.3",

diff --git a/packages/BUILD.bazel b/packages/BUILD.bazel
@@ -105,7 +105,8 @@ filegroup(
       "//packages/kbn-securitysolution-hook-utils:build_types",
       "//packages/kbn-securitysolution-io-ts-alerting-types:build_types",
       "//packages/kbn-securitysolution-io-ts-list-types:build_types",
-      "//packages/kbn-securitysolution-io-ts-types",
+      "//packages/kbn-securitysolution-io-ts-types:build_types",
+      "//packages/kbn-securitysolution-list-api:build_types",
   ],
 )
 

diff --git a/packages/kbn-securitysolution-list-api/BUILD.bazel b/packages/kbn-securitysolution-list-api/BUILD.bazel
@@ -1,10 +1,10 @@
-load("@npm//@bazel/typescript:index.bzl", "ts_config", "ts_project")
-load("@build_bazel_rules_nodejs//:index.bzl", "js_library", "pkg_npm")
-load("//src/dev/bazel:index.bzl", "jsts_transpiler")
+load("@npm//@bazel/typescript:index.bzl", "ts_config")
+load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
+load("//src/dev/bazel:index.bzl", "jsts_transpiler", "pkg_npm", "pkg_npm_types", "ts_project")
 
 PKG_BASE_NAME = "kbn-securitysolution-list-api"
-
 PKG_REQUIRE_NAME = "@kbn/securitysolution-list-api"
+TYPES_PKG_REQUIRE_NAME = "@types/kbn__securitysolution-list-api"
 
 SOURCE_FILES = glob(
   [
@@ -85,7 +85,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = RUNTIME_DEPS + [":target_node", ":target_web", ":tsc_types"],
+  deps = RUNTIME_DEPS + [":target_node", ":target_web"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )
@@ -104,3 +104,20 @@ filegroup(
   ],
   visibility = ["//visibility:public"],
 )
+
+pkg_npm_types(
+  name = "npm_module_types",
+  srcs = SRCS,
+  deps = [":tsc_types"],
+  package_name = TYPES_PKG_REQUIRE_NAME,
+  tsconfig = ":tsconfig",
+  visibility = ["//visibility:public"],
+)
+
+filegroup(
+  name = "build_types",
+  srcs = [
+    ":npm_module_types",
+  ],
+  visibility = ["//visibility:public"],
+)
diff --git a/packages/kbn-securitysolution-list-api/package.json b/packages/kbn-securitysolution-list-api/package.json
@@ -5,6 +5,5 @@
   "license": "SSPL-1.0 OR Elastic License 2.0",
   "browser": "./target_web/index.js",
   "main": "./target_node/index.js",
-  "types": "./target_types/index.d.ts",
   "private": true
 }
diff --git a/packages/kbn-securitysolution-list-api/src/list_api/index.ts b/packages/kbn-securitysolution-list-api/src/list_api/index.ts
@@ -46,6 +46,14 @@ import {
   ImportListParams,
 } from './types';
 
+export type {
+  ApiParams,
+  DeleteListParams,
+  ExportListParams,
+  FindListsParams,
+  ImportListParams,
+} from './types';
+
 const findLists = async ({
   http,
   cursor,

diff --git a/packages/kbn-securitysolution-list-hooks/BUILD.bazel b/packages/kbn-securitysolution-list-hooks/BUILD.bazel
@@ -42,7 +42,7 @@ RUNTIME_DEPS = [
 TYPES_DEPS = [
   "//packages/kbn-securitysolution-hook-utils:npm_module_types",
   "//packages/kbn-securitysolution-io-ts-list-types:npm_module_types",
-  "//packages/kbn-securitysolution-list-api",
+  "//packages/kbn-securitysolution-list-api:npm_module_types",
   "//packages/kbn-securitysolution-list-constants",
   "//packages/kbn-securitysolution-list-utils",
   "//packages/kbn-securitysolution-utils",

diff --git a/yarn.lock b/yarn.lock
@@ -5916,6 +5916,10 @@
   version "0.0.0"
   uid ""
 
+"@types/kbn__securitysolution-list-api@link:bazel-bin/packages/kbn-securitysolution-list-api/npm_module_types":
+  version "0.0.0"
+  uid ""
+
 "@types/keyv@*":
   version "3.1.1"
   resolved "https://registry.yarnpkg.com/@types/keyv/-/keyv-3.1.1.tgz#e45a45324fca9dab716ab1230ee249c9fb52cfa7"