Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): splits types from code on @kbn/securitysolution-list-api #121680

Merged
merged 4 commits into from
Dec 21, 2021
Merged

chore(NA): splits types from code on @kbn/securitysolution-list-api #121680

merged 4 commits into from
Dec 21, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 20, 2021

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Dec 20, 2021
@mistic mistic requested a review from jbudz December 20, 2021 17:59
@mistic mistic marked this pull request as ready for review December 20, 2021 19:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic mistic merged commit d7a7f6b into elastic:main Dec 21, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 21, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/securitysolution-list-api 41 58 +17

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/securitysolution-list-api 5 0 -5
kibana 922 927 +5
total -0
Unknown metric groups

API count

id before after diff
@kbn/securitysolution-list-api 42 59 +17

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mibragimov pushed a commit to mibragimov/kibana that referenced this pull request Dec 22, 2021
@mistic
chore(NA): splits types from code on @kbn/securitysolution-list-api (e…
dfc2f61 
…lastic#121680)

* chore(NA): splits types from code on @kbn/securitysolution-list-api

* chore(NA): export type only

* chore(NA): merge and solve conflicts wth main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibana-ci @jbudz @kibanamachine