-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix:revolving dot issue #140 #141
Conversation
I am not sure about what package version should I give it. |
@Atishay-J Let's update the props type of Please feel free to open a PR for other spinner if you like. |
src/loader/RevolvingDot.tsx
Outdated
@@ -5,13 +5,14 @@ import { BaseProps, DEFAULT_COLOR, DEFAULT_WAI_ARIA_ATTRIBUTE } from '../type' | |||
interface RevolvingDotProps extends BaseProps { | |||
radius?: string | number | |||
secondaryColor?: string | |||
strokeWidth?: string | number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rethink about the props type for the spinner. Number will make more sense and we can limit it to supported range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we can keep it a number.
But I think we should not have a limit to it, people may want to have granular control for the component.
In this case they can mix and match radius
and strokeWidth
according to their preference
I think it should be a major update, existing spinner would change its looks and feel silently. |
This fixes Revolving dot issue #140
Both the circles are now scaling up and down properly without getting cropped.
Some additions