Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RevolvingDot is not scalling properly #140

Closed
Atishay-J opened this issue Sep 2, 2022 · 1 comment
Closed

RevolvingDot is not scalling properly #140

Atishay-J opened this issue Sep 2, 2022 · 1 comment
Assignees
@Atishay-J

Comments

@Atishay-J
Copy link
Contributor

Atishay-J commented Sep 2, 2022 •
edited
Loading

When I try to change the size of RevolvingDot it doesn't adjust properly.
It gets cropped, also the inner ring is not auto-adjusting with the radius of the outer circle.

revolving dot 2
Revolving dot 1

I am using the latest version of react-loader-spinner

Here is a link to codeSandbox which represents this issue
@Atishay-J
Copy link
Contributor Author

If possible, can you assign this issue to me,
would like to work on it.

@mhnpd mhnpd assigned mhnpd and Atishay-J and unassigned mhnpd Sep 2, 2022
@Atishay-J Atishay-J mentioned this issue Sep 3, 2022
Merged
mhnpd pushed a commit that referenced this issue Sep 8, 2022
@Atishay-J
Fix:revolving dot issue #140 (#141)
906a275 
* WIP: Fix initial canvas and ring overflow issue

* Fix: Revolving dot scaling issue

* Chore: Remove unused code

* Test: change test cases

* Refactor: Change 
adius and strokeWidth type, also increase default loader size

* Test: Update test for new default configuration
@mhnpd mhnpd closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Atishay-J Atishay-J

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhnpd @Atishay-J