-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 1.x branch for Jasmine-Reporters #331
Conversation
Same problem for me, hindering my travis-ci tests to pass |
+1 |
+1 Same here |
This does look like the correct fix, hopefully it gets merged soon. |
Make sure jasmine-reporters works off the jasmine1.x branch.
The #333 pull request has a better solution for this, using |
@edi9999 the reason for
|
This is true. I later repented and agreed that In the unlikely possibility that In short, I was being lazy and suggesting something that would work, but in some ways is almost as risky as #333 is a safer solution to the same problem. |
@bloveridge @edi9999 Fair enough. Closing in favor of #333. |
Make sure jasmine-reporters works off the jasmine1.x branch.
Due to: larrymyers/jasmine-reporters#52 and how
jasmine-node
is specifying the version forjasmine-reporters
, it is now pulling in the 2.0 version ofjasmine-reporters
. This patch limitsjasmine-reporters
to the 1.x branch, which keepsjasmine-node
working.