Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1.x branch for Jasmine-Reporters #331

Closed
wants to merge 1 commit into from

Conversation

jgrund
Copy link

@jgrund jgrund commented Jul 3, 2014

Make sure jasmine-reporters works off the jasmine1.x branch.

Due to: larrymyers/jasmine-reporters#52 and how jasmine-node is specifying the version for jasmine-reporters, it is now pulling in the 2.0 version of jasmine-reporters. This patch limits jasmine-reporters to the 1.x branch, which keeps jasmine-node working.

@edi9999
Copy link

edi9999 commented Jul 3, 2014

Same problem for me, hindering my travis-ci tests to pass

@dschnei
Copy link

dschnei commented Jul 3, 2014

+1
hindering to pass my jenkins

@wayneseymour
Copy link

+1 same as @dschnei and @jgrund

@johnsonw
Copy link

johnsonw commented Jul 3, 2014

+1 Same here

@putermancer
Copy link

This does look like the correct fix, hopefully it gets merged soon.

Make sure jasmine-reporters works off the jasmine1.x branch.
@edi9999
Copy link

edi9999 commented Jul 8, 2014

The #333 pull request has a better solution for this, using ~1.0.0 We should close this.

@jgrund
Copy link
Author

jgrund commented Jul 16, 2014

@edi9999 the reason for <2.0.0 specifically comes from @bloveridge. When closing larrymyers/jasmine-reporters#52 he wrote:

Jasmine 1.x support is still available on the jasmine1.x branch, with the 1.0.0 tag and 1.0.0 was also published to npm -- using jasmine-reporters@<2.0.0 should work great inside your package.json.

@putermancer
Copy link

This is true. I later repented and agreed that ~1.0.0 is better (much safer) than <2.0.0.

In the unlikely possibility that [email protected] gets released with significant changes -- such as to the method signature for JUnitXmlReporter to accept an options object instead of ordered arguments (a pull request has been opened for this in the past) -- <2.0.0 could cause people to break all over again, whereas ~1.0.0 would not.

In short, I was being lazy and suggesting something that would work, but in some ways is almost as risky as >=0.2.0.

#333 is a safer solution to the same problem.

@jgrund
Copy link
Author

jgrund commented Jul 16, 2014

@bloveridge @edi9999 Fair enough. Closing in favor of #333.

@jgrund jgrund closed this Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants