Support Jasmine 2.0

[tebriel]

Any plans to support Jasmine 2.0?
I've got a large amount of the work done for jasmine-node to upgrade to Jasmine 2.0, but I can't use these reporters since Pivotal changed the reporter spec.
You can use the Jasmine2.0 branch to test/work with or you can let me know and I'll plug them back in.
https://github.com/mhevery/jasmine-node/tree/Jasmine2.0

[putermancer]

Supporting Jasmine 2.0 is something I would like to accomplish but haven’t yet spent any time on. I’m hoping to get around to this in the next few weeks — we’ll see how it goes.
On March 6, 2014 at 3:01:41 PM, Chris M ([email protected]) wrote:

Any plans to support Jasmine 2.0?
I've got a large amount of the work done for jasmine-node to upgrade to Jasmine 2.0, but I can't use these reporters since Pivotal changed the reporter spec.
You can use the Jasmine2.0 branch to test/work with or you can let me know and I'll plug them back in.
https://github.com/mhevery/jasmine-node/tree/Jasmine2.0

—
Reply to this email directly or view it on GitHub.

[tebriel]

Okay, sounds good. I rewrote the jasmine-node terminal reporter (which may
or may not have been based off of yours), so if you need some guidance, let
me know.
Thanks

On Sunday, March 9, 2014, Ben Loveridge [email protected] wrote:

Supporting Jasmine 2.0 is something I would like to accomplish but haven't
yet spent any time on. I'm hoping to get around to this in the next few
weeks -- we'll see how it goes.
On March 6, 2014 at 3:01:41 PM, Chris M ([email protected]javascript:_e(%7B%7D,'cvml','[email protected]');)
wrote:

Any plans to support Jasmine 2.0?
I've got a large amount of the work done for jasmine-node to upgrade to
Jasmine 2.0, but I can't use these reporters since Pivotal changed the
reporter spec.
You can use the Jasmine2.0 branch to test/work with or you can let me know
and I'll plug them back in.
https://github.com/mhevery/jasmine-node/tree/Jasmine2.0

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//issues/52#issuecomment-37140577
.

[tniswong]

+1

[radegran]

+1

[putermancer]

I'm working on this now. I've just pushed up a new branch jasmine2 which includes an updated JUnitXmlReporter. Currently it works in PhantomJS, env.js is broken (don't know why yet), and node.js is untested yet.

Feel free to check it out and let me know how it is working. Make special note of where the reporter is registered now (jasmineRequire.JUnitXmlReporter instead of jasmine.JUnitXmlReporter) and the fact that the constructor signature has changed (it now takes a single options object instead of ordered parameters).

Also, consolidateAll is a new option and is the new default behavior.

[putermancer]

@tebriel I've just pushed up what I think are the final refactors for the JUnitXmlReporter. I've made it much more friendly to expose these to node: jasmine-reporters now exports an object with each of the reporters rather than exposing them on any jasmine globals / etc.

It should still work with jasmine-node, but I'm sure you'd be much quicker at testing that out and preparing to restore it in that project.

I'd love to hear how this works out. Now I'm going to work on the remaining reporters.

[putermancer]

NUnitXmlReporter and TerminalReporter are now updated for Jasmine 2.

[tebriel]

Checking this out now.

[tebriel]

Cursory glance looks good, spinning up a jenkins instance, 'cause that's the best way I have to test it :D

[putermancer]

Awesome, thanks for helping, Chris, I haven't had a chance to get a Jenkins instance going yet. It is on my list, but at this point I probably won't get to it until Monday evening myself - and I still  need to get Teamcity and TAP reporters updated. So this is a big help. 

It would be great to test both JUnit and NUmit XML files, and with various stages of xdescribe/xit and probably even ddescribe/iit. 
—
Ben Loveridge (phone--sorry for typos)

On Sat, Apr 19, 2014 at 7:51 AM, Chris M [email protected] wrote:

Cursory glance looks good, spinning up a jenkins instance, 'cause that's the best way I have to test it :D

Reply to this email directly or view it on GitHub:
#52 (comment)

[tebriel]

NEAT!

[tebriel]

Hey, if the savePath doesn't exist, you don't create it, was that intentional? It just fails silently (unless I should be looking for errors somewhere)

[putermancer]

I wouldn't say that's exactly intentional, but it is the way it behaved previously. I would be open to changing this, I just haven't spent the time figuring out the best way to recursively create the directory if it doesn't exist (manually, using something like node-fs, etc) in node.js -- turns out PhantomJS takes care of it automatically, which is great, but I don't currently have a node solution.

[tebriel]

I know there's a mkdirp node module, if that's your style. I'm not against keeping the old functionality, kind of neutral on it, all of our CI scripts at work have mkdir -p reports/ in them.

[putermancer]

Awesome, thanks for the suggestion. mkdirp seems rather more popular than the other package I'd looked at (85k installations today alone? Okay, I can go with that...) and it was easy to implement.

I just pushed a change for both junit and nunit that should make sure the path exists. Try it out and let me know how it goes!

[tebriel]

Verified working for junitxml. Will get around to adding nunit later today. Still sorting out a random inconsistency with something else.

[putermancer]

Awesome, glad it's working and thanks for helping out with this! —
Ben Loveridge (phone--sorry for typos)

On Sat, Apr 19, 2014 at 9:16 AM, Chris M [email protected] wrote:

Verified working for junitxml. Will get around to adding nunit later today. Still sorting out a random inconsistency with something else.

Reply to this email directly or view it on GitHub:
#52 (comment)

[tebriel]

I don't have anything that can test nunit stuff, but the file looks like a bunch of xml :D --nunit option has been added.

[putermancer]

Awesome! I think there is a Jenkins plugin, but I did a pretty thorough manual test and comparison on those files, and all the previous unit tests on its stricter still pass, so I'm not overly concerned. —
Ben Loveridge (phone--sorry for typos)

On Sat, Apr 19, 2014 at 9:44 AM, Chris M [email protected] wrote:

I don't have anything that can test nunit stuff, but the file looks like a bunch of xml :D --nunit option has been added.

Reply to this email directly or view it on GitHub:
#52 (comment)

[putermancer]

TapReporter (Test Anything Protocol) finished. Only Teamcity remains -- hopefully tomorrow.

[tebriel]

👍

On Sunday, April 20, 2014, Ben Loveridge [email protected] wrote:

TapReporter (Test Anything Protocol) finished. Only Teamcity remains --
hopefully tomorrow.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/52#issuecomment-40906078
.

[putermancer]

TeamCity has been updated and pushed. All reporters have now been updated to work with Jasmine 2.x, and I have fixed all the issues I was able to discover.

It would be great if anybody else using these reporters would pull down the new branch and make sure things are working as expected. Let me know of any issues you find, and I'll get them fixed (or you can submit a pull request).

If I don't hear of any problems by the end of the week, I'm going to promote this new branch to master and publish a new npm module. When that happens, I'll probably bump the version from 0.4.x all the way to 2.0.0 so the major version number matches the compatible Jasmine version.

[karlkras]

So does this mean 1.3 Jasmine support is history?

[tebriel]

No, I plan to keep up maintenance for bugs and such, at least for a while.

Sent from my iPhone

On Apr 21, 2014, at 8:45 PM, "karlkras" <[email protected]mailto:[email protected]> wrote:

So does this mean 1.3 Jasmine support is history?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/52#issuecomment-40992946.

[putermancer]

Jasmine 1.x will still be supported for a while, but not as the main development branch. 'master' will be the jasmine2 reporters, and there will be a jasmine-1.x branch (or similar) with the current reporters. 

New features will probably only make it into 1.x if there are pull requests or they are severely needed. Fortunately, these reporters don't usually need much attention. 
—
Ben Loveridge (phone--sorry for typos)

On Mon, Apr 21, 2014 at 6:45 PM, karlkras [email protected]
wrote:

So does this mean 1.3 Jasmine support is history?

Reply to this email directly or view it on GitHub:
#52 (comment)

[tebriel]

Oh, sorry, thought this was jasmine-node. Got confused!

Sent from my iPhone

On Apr 21, 2014, at 9:06 PM, "Ben Loveridge" <[email protected]mailto:[email protected]> wrote:

Jasmine 1.x will still be supported for a while, but not as the main development branch. 'master' will be the jasmine2 reporters, and there will be a jasmine-1.x branch (or similar) with the current reporters.

New features will probably only make it into 1.x if there are pull requests or they are severely needed. Fortunately, these reporters don't usually need much attention.
—
Ben Loveridge (phone--sorry for typos)

On Mon, Apr 21, 2014 at 6:45 PM, karlkras <[email protected]mailto:[email protected]>
wrote:

So does this mean 1.3 Jasmine support is history?

Reply to this email directly or view it on GitHub:
#52 (comment)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/52#issuecomment-40994017.

[karlkras]

Have you been able to revisit issue #28 (i think that's right. Issue with phantomjs reporter not working on win 7 64bit)? Sorry to keep poking at this, but it would help me immensely if we could get this worked out. Will you take beer as an incentive :)  ?

Sent from Yahoo Mail on Android

[karlkras]

Hmm, now I'm confused...

Sent from Yahoo Mail on Android

[putermancer]

Now that I have the reporters working with jasmine 2, I do hope to spend some time working on the windows 7 issue this week. This is precisely the kind of fix that would land in both branches. The file writing logic is the same in both places, and can be easily maintained. —
Ben Loveridge (phone--sorry for typos)

On Mon, Apr 21, 2014 at 7:14 PM, karlkras [email protected]
wrote:

Hmm, now I'm confused...

Sent from Yahoo Mail on Android

Reply to this email directly or view it on GitHub:
#52 (comment)

[karlkras]

that's good to hear Ben... anything I can do to assist please let me know.

[putermancer]

Please test the fix I just pushed up to the jasmine2 branch and let me know how it goes for you. More details in the comment stream for #28.

[JonnyRa]

@bloveridge The comment about the branches is a bit confusing. It seems master is still old jasmine. I nearly got caught out by that - I'm not familiar with git and didn't realise visibility of branches was controlled by a drop down. Anyway this seems to be working fine for me. I've just set up CI with selenium. I've documented this at http://stackoverflow.com/questions/24311215/html-javascript-sharing-script-lists-or-doing-ci-with-jasmine-and-selenium/24365820#24365820. I hacked the library around to achieve it but thought people might be interested

[johnsonw]

I'm using the junit reporter with minijasminenode and it appears to be working pretty good so far. How come this hasn't been merged into master yet?

[putermancer]

Sheer forgetfulness, it's coming very soon, thanks for the bump :)

[jgrund]

Looking forward to this as well.

[johnsonw]

Thanks bloveridge. Just a heads up that I needed the jasmine2 support so I created a temporary fork here: https://github.com/chum-bucket/jasmine2-reporters

I basically replaced the master branch with what was on the jasmine2 branch. Let me know when you've made the update and I will remove this repository.

[putermancer]

Thanks, I'm working on this and some related changes now and I'll put a comment here when I'm done.

[putermancer]

@tebriel et al,

This has been merged to master, tagged as 2.0.0 and published to npm.

Jasmine 1.x support is still available on the jasmine1.x branch, with the 1.0.0 tag and 1.0.0 was also published to npm -- using jasmine-reporters@<2.0.0 should work great inside your package.json.

Thanks everyone for your help and patience, sorry it took so long!