Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our one of our projects we're using redis-namespace which below 2.0 try to implicitly namespace keys transparently.
For example for script calls it does the following as an example:
https://github.com/resque/redis-namespace/blob/30d42177d8abfdf89e502c1a98aab7d923c2a133/lib/redis/namespace.rb#L372
Well, we're going to evaluate keeping using redis-namespace on the future, but we cannot afford the migration right now, and we realized that we cannot make use of the new
conflict
resolution features because of this:sidekiq-unique-jobs/redis/delete_job_by_digest.lua
Line 1 in 9d1ee6c
As it's going to build a string just like
queue:default
when in our redis service should beapp_name:queue:default
Solution
We provided a slightly change so the ruby code provides which it thinks is the whole key to search for jobs then
redis-namespace
will add the namespace transparently.Please let me know what you think, maybe we should add some kind of not on README about the
redis-namespace
usage or any other thing to clarify the previous situation and if this is accepted in some way evaluate if it's correct or not.