Do not build keys on lua scripts

On this way users of sidekiq-unique-jobs that made use of redis-namespace < 2.0 could use it.
mhenrixon · Nov 13, 2018 · bea25a8 · bea25a8
1 parent 9d1ee6c
commit bea25a8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/sidekiq_unique_jobs/on_conflict/replace.rb b/lib/sidekiq_unique_jobs/on_conflict/replace.rb
@@ -25,7 +25,7 @@ def call(&block)
 
       # Delete the job from either schedule, retry or the queue
       def delete_job_by_digest
-        Scripts.call(:delete_job_by_digest, nil, keys: [queue, unique_digest])
+        Scripts.call(:delete_job_by_digest, nil, keys: ["queue:#{queue}"], argv: [unique_digest])
       end
 
       # Delete the keys belonging to the job

diff --git a/redis/delete_job_by_digest.lua b/redis/delete_job_by_digest.lua
@@ -1,5 +1,5 @@
-local queue         = "queue:" .. KEYS[1]
-local unique_digest = KEYS[2]
+local queue         = KEYS[1]
+local unique_digest = ARGV[1]
 
 local function delete_from_sorted_set(name, digest)
   local per   = 50