Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cgi | Fix isapi.ThreadPoolExtension's printing of exception traceback #2312

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jul 22, 2024

cgi.escape is deprecated since Python 3.2 and removed in Python 3.8 https://docs.python.org/3.7/library/cgi.html#cgi.escape
The entire cgi module is removed in Python 3.13: https://peps.python.org/pep-0594/#deprecated-modules

This would be caught by mypy with attr-defined turned back on, or by pyright with reportAttributeAccessIssue back on.

@Avasam Avasam requested a review from mhammond July 22, 2024 21:21
Copy link

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but i have no commit rights here.

@mhammond mhammond merged commit 1856d1f into mhammond:main Oct 4, 2024
31 checks passed
@Avasam Avasam deleted the remove-cgi branch October 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants