Fix isapi.ThreadPoolExtension's printing of exception traceback bro…

…ken on Python 3.8+
mhammond · Jul 22, 2024 · 249c8bc · 249c8bc
1 parent a9010f3
commit 249c8bc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -15,6 +15,7 @@ Coming in build 307, as yet unreleased
 --------------------------------------
 
 ### pywin32
+* Fix `isapi.ThreadPoolExtension`'s printing of exception traceback broken on Python 3.8+ (#2312, @Avasam)
 * Add RealGetWindowClass (#2299, @CristiFati)
 * Make it compile on Python 3.13 (#2260, @clin1234)
 * Fixed accidentally trying to raise a `str` instead of an `Exception` in (#2270, @Avasam)

diff --git a/isapi/threaded_extension.py b/isapi/threaded_extension.py
@@ -156,7 +156,7 @@ def HandleDispatchError(self, ecb):
         limit = None
         try:
             try:
-                import cgi
+                import html
 
                 ecb.SendResponseHeaders(
                     "200 OK", "Content-type: text/html\r\n\r\n", False
@@ -169,8 +169,8 @@ def HandleDispatchError(self, ecb):
                 bold = list.pop()
                 print(
                     "<PRE>{}<B>{}</B></PRE>".format(
-                        cgi.escape("".join(list)),
-                        cgi.escape(bold),
+                        html.escape("".join(list)),
+                        html.escape(bold),
                     ),
                     file=ecb,
                 )