Merge cockroachdb#110828 cockroachdb#110869

110828: server: create cluster setting for persisted insights r=maryliag a=maryliag

A new table for persisted Insights will be created, and the endpoints to retrive Insights information will be able to use it. This commit creates a cluster settings that can be used to disabled its usage, in case there is a problem with its content.

Fixes cockroachdb#110813

Release note: None

110869: go.mod: bump Pebble to 57e248f9c4d8 r=RaduBerinde a=itsbilal

```
57e248f9 open: Ratchet nextFileNum ahead of objprovider objects
75bc026c db: add invariant for ValueAndErr
61f84632 metamorphic: 0 suffix should be suffixless in the RandomSeparator
be158640 manifest: remove invalid comment
```

Release note: None.

Epic: none

Co-authored-by: maryliag <[email protected]>
Co-authored-by: Bilal Akhtar <[email protected]>

DEPS.bzl

@@ -1609,10 +1609,10 @@ def go_deps():
         patches = [
             "@com_github_cockroachdb_cockroach//build/patches:com_github_cockroachdb_pebble.patch",
         ],
-        sha256 = "781188006acfa57acaabaf042badd129ec60a9244da17d61f951816ca6612884",
-        strip_prefix = "github.com/cockroachdb/[email protected]20230915152238-6d6570bf1e25",
+        sha256 = "834a73eec5306e2ae0a4538bee36c423f634e89612896d2693b6ff6db7ae06f9",
+        strip_prefix = "github.com/cockroachdb/[email protected]20230919032055-57e248f9c4d8",
         urls = [
-            "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230915152238-6d6570bf1e25.zip",
+            "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230919032055-57e248f9c4d8.zip",
         ],
     )
     go_repository(

build/bazelutil/distdir_files.bzl

@@ -322,7 +322,7 @@ DISTDIR_FILES = {
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/go-test-teamcity/com_github_cockroachdb_go_test_teamcity-v0.0.0-20191211140407-cff980ad0a55.zip": "bac30148e525b79d004da84d16453ddd2d5cd20528e9187f1d7dac708335674b",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/gostdlib/com_github_cockroachdb_gostdlib-v1.19.0.zip": "c4d516bcfe8c07b6fc09b8a9a07a95065b36c2855627cb3514e40c98f872b69e",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/logtags/com_github_cockroachdb_logtags-v0.0.0-20230118201751-21c54148d20b.zip": "ca7776f47e5fecb4c495490a679036bfc29d95bd7625290cfdb9abb0baf97476",
-    "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230915152238-6d6570bf1e25.zip": "781188006acfa57acaabaf042badd129ec60a9244da17d61f951816ca6612884",
+    "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230919032055-57e248f9c4d8.zip": "834a73eec5306e2ae0a4538bee36c423f634e89612896d2693b6ff6db7ae06f9",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/redact/com_github_cockroachdb_redact-v1.1.5.zip": "11b30528eb0dafc8bc1a5ba39d81277c257cbe6946a7564402f588357c164560",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/returncheck/com_github_cockroachdb_returncheck-v0.0.0-20200612231554-92cdbca611dd.zip": "ce92ba4352deec995b1f2eecf16eba7f5d51f5aa245a1c362dfe24c83d31f82b",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/sentry-go/com_github_cockroachdb_sentry_go-v0.6.1-cockroachdb.2.zip": "fbb2207d02aecfdd411b1357efe1192dbb827959e36b7cab7491731ac55935c9",

go.mod

@@ -115,7 +115,7 @@ require (
 	github.com/cockroachdb/go-test-teamcity v0.0.0-20191211140407-cff980ad0a55
 	github.com/cockroachdb/gostdlib v1.19.0
 	github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b
-	github.com/cockroachdb/pebble v0.0.0-20230915152238-6d6570bf1e25
+	github.com/cockroachdb/pebble v0.0.0-20230919032055-57e248f9c4d8
 	github.com/cockroachdb/redact v1.1.5
 	github.com/cockroachdb/returncheck v0.0.0-20200612231554-92cdbca611dd
 	github.com/cockroachdb/stress v0.0.0-20220803192808-1806698b1b7b

go.sum

@@ -492,8 +492,8 @@ github.com/cockroachdb/gostdlib v1.19.0/go.mod h1:+dqqpARXbE/gRDEhCak6dm0l14AaTy
 github.com/cockroachdb/logtags v0.0.0-20211118104740-dabe8e521a4f/go.mod h1:Vz9DsVWQQhf3vs21MhPMZpMGSht7O/2vFW2xusFUVOs=
 github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b h1:r6VH0faHjZeQy818SGhaone5OnYfxFR/+AzdY3sf5aE=
 github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b/go.mod h1:Vz9DsVWQQhf3vs21MhPMZpMGSht7O/2vFW2xusFUVOs=
-github.com/cockroachdb/pebble v0.0.0-20230915152238-6d6570bf1e25 h1:3TmXZ906ySGZMwTAS0YWzP8hNg4gUIeDmXvu5gEU2PQ=
-github.com/cockroachdb/pebble v0.0.0-20230915152238-6d6570bf1e25/go.mod h1:nindLFinxeDPjP4qI9LtVHAwDef57/0s5KMfWgdktQc=
+github.com/cockroachdb/pebble v0.0.0-20230919032055-57e248f9c4d8 h1:G4GOFRvT6BaRFB3jVSzMl0QtvwuKiina2O1QCehokjg=
+github.com/cockroachdb/pebble v0.0.0-20230919032055-57e248f9c4d8/go.mod h1:nindLFinxeDPjP4qI9LtVHAwDef57/0s5KMfWgdktQc=
 github.com/cockroachdb/redact v1.1.3/go.mod h1:BVNblN9mBWFyMyqK1k3AAiSxhvhfK2oOZZ2lK+dpvRg=
 github.com/cockroachdb/redact v1.1.5 h1:u1PMllDkdFfPWaNGMyLD1+so+aq3uUItthCFqzwPJ30=
 github.com/cockroachdb/redact v1.1.5/go.mod h1:BVNblN9mBWFyMyqK1k3AAiSxhvhfK2oOZZ2lK+dpvRg=

pkg/server/cluster_settings.go

@@ -42,3 +42,11 @@ var StatsActivityUIEnabled = settings.RegisterBoolSetting(
 	"sql.stats.activity.ui.enabled",
 	"enable the combined statistics endpoint to get data from the system activity tables",
 	true)
+
+// PersistedInsightsUIEnabled controls if the insights endpoint uses
+// the persisted statement_execution_insights and transaction_execution_insights tables.
+var PersistedInsightsUIEnabled = settings.RegisterBoolSetting(
+	settings.TenantWritable,
+	"sql.stats.persisted_insights.ui.enabled",
+	"enable the insights endpoint to get data from the persisted insights tables",
+	false)